fix(FE selection sorting): fix emoji and selection id = 0 handling (#539

)

- remove emojis to sort by the real value
- correct handling of selection-id = 0
- code cleanup

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>

src/shared/components/ncTable/mixins/columnsTypes/selection.js

@@ -28,14 +28,20 @@ export default class SelectionColumn extends AbstractSelectionColumn {
 	sort(mode) {
 		const factor = mode === 'DESC' ? -1 : 1
 		return (rowA, rowB) => {
-			const selectionIdA = rowA.data.find(item => item.columnId === this.id)?.value || null
-			const valueA = selectionIdA !== null ? this.selectionOptions.find(item => item.id === selectionIdA)?.label : ''
-			const selectionIdB = rowB.data.find(item => item.columnId === this.id)?.value || null
-			const valueB = selectionIdB !== null ? this.selectionOptions.find(item => item.id === selectionIdB)?.label : ''
+			const selectionIdA = rowA.data.find(item => item.columnId === this.id)?.value ?? null
+			const vA = selectionIdA !== null ? this.selectionOptions.find(item => item.id === selectionIdA)?.label : ''
+			const valueA = this.removeEmoji(vA).trim()
+			const selectionIdB = rowB.data.find(item => item.columnId === this.id)?.value ?? null
+			const vB = selectionIdB !== null ? this.selectionOptions.find(item => item.id === selectionIdB)?.label : ''
+			const valueB = this.removeEmoji(vB).trim()
 			return ((valueA < valueB) ? -1 : (valueA > valueB) ? 1 : 0) * factor
 		}
 	}
 
+	removeEmoji(str) {
+		return str.replace(/([#0-9]\u20E3)|[\xA9\xAE\u203C\u2047-\u2049\u2122\u2139\u3030\u303D\u3297\u3299][\uFE00-\uFEFF]?|[\u2190-\u21FF][\uFE00-\uFEFF]?|[\u2300-\u23FF][\uFE00-\uFEFF]?|[\u2460-\u24FF][\uFE00-\uFEFF]?|[\u25A0-\u25FF][\uFE00-\uFEFF]?|[\u2600-\u27BF][\uFE00-\uFEFF]?|[\u2900-\u297F][\uFE00-\uFEFF]?|[\u2B00-\u2BF0][\uFE00-\uFEFF]?|(?:\uD83C[\uDC00-\uDFFF]|\uD83D[\uDC00-\uDEFF])[\uFE00-\uFEFF]?/g, '')
+	}
+
 	isSearchStringFound(cell, searchString) {
 		return super.isSearchStringFound(this.getLabel(cell.value), cell, searchString)
 	}

src/shared/components/ncTable/partials/TableHeaderColumnOptions.vue

@@ -343,10 +343,10 @@ export default {
 				this.sortMode = null
 				this.localViewSetting.sorting = null
 			} else {
-				this.sortMode = mode
 				if (mode !== 'ASC' && mode !== 'DESC') {
 					return
 				}
+				this.sortMode = mode
 				this.localViewSetting.sorting = [{
 					columnId: this.column.id,
 					mode,