Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV download not possible #237

Closed
connium opened this issue Apr 21, 2023 · 1 comment
Closed

CSV download not possible #237

connium opened this issue Apr 21, 2023 · 1 comment
Assignees
@datenangebot
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working

Comments

@connium
Copy link
Contributor

connium commented Apr 21, 2023 •
edited
Loading

When trying to download a table as csv file, nothing happens after clicking on the download button.

Steps to reproduce the behavior

  1. In a table with some data (e.g. the tutorial table) click on "download as csv" from the menu.
  2. Nothing happens.

Expected behavior

A file download will start.

Additional information

In the browser console the following error occurs:

TypeError: this[n] is not a function
    getValueByColumnType exportTableMixin.js:37
    downloadCsv exportTableMixin.js:21
    downloadCsv exportTableMixin.js:18
    downloadCsv exportTableMixin.js:14
    csv NcTable.vue:1
    VueJS 4
    csv CustomTable.vue:1
    VueJS 4
    downloadCSV TableHeader.vue:91
    VueJS 4
    onClick index.module.js:2
    VueJS 3
vue.runtime.esm.js:3049:8

Environment

  • Nextcloud version: 25.0.5
  • Tables version: 0.4.0
  • Browser: Firefox 112.0.1
  • Client OS: Ubuntu
@datenangebot datenangebot added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Apr 25, 2023
@datenangebot datenangebot self-assigned this Apr 25, 2023
datenangebot pushed a commit that referenced this issue Apr 25, 2023
bugfix: #237 debug message broke because of a missing condition case
5a83c29 
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot datenangebot added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Apr 25, 2023
datenangebot pushed a commit that referenced this issue Apr 25, 2023
Merge pull request #243 from nextcloud/fix/#237-csvExportError
7ac80b6 
bugfix: #237 debug message broke because of a missing condition case
@datenangebot datenangebot added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 25, 2023
@juliusknorr
Copy link
Member

@datenangebot Looks like this can also be closed with the fix in #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datenangebot datenangebot

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliusknorr @connium @datenangebot