Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column sum for views is incorrectly calculated #781

Open
AndyScherzinger opened this issue Jan 18, 2024 · 9 comments
Open

Column sum for views is incorrectly calculated #781

AndyScherzinger opened this issue Jan 18, 2024 · 9 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@AndyScherzinger
Copy link
Member

Steps to reproduce

  1. create a table with columns
  2. create views with one less column

Expected behavior

sum of columns for views matches the views

Actual behavior

sum of columns for views matches the number of columns of the table

2024-01-18 21_52_18-Hub 8 feature list - Tables - Nextcloud – Mozilla Firefox

Tables app version

0.6.5

Browser

FF121

Client operating system

Win11Pro

Operating system

No response

Web server

None

PHP engine version

None

Database

None

Additional info

c.nc.c

@AndyScherzinger AndyScherzinger added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 18, 2024
@AndyScherzinger AndyScherzinger changed the title Column sum for views over is incorrectly calculated Column sum for views is incorrectly calculated Jan 18, 2024
@enjeck
Copy link
Contributor

enjeck commented Jan 19, 2024

To be sure, we expect total to be the sum of the rows and column values? Because it appears even the rows sum isn't always right too.

image

@juliusknorr
Copy link
Member

Total is not supposed to be the sum but the overall row/column count, as a row could be part of multiple views. However I get how the visual presentation can be a bit confusing.

Maybe @nextcloud/designers have any input to that.

@datenangebot
Copy link
Collaborator

Maybe just renaming the "Total" into "Total counter"...

@jancborchardt
Copy link
Member

So I understand the "Total" for rows, but do we need a total for columns at all? That's not really a common/relevant thing to be counted in a table or spreadsheet, which also causes this confusion.

@enjeck
Copy link
Contributor

enjeck commented Jan 24, 2024

So we can remove the column count to address this issue?

@AndyScherzinger
Copy link
Member Author

Yes 👍

@datenangebot
Copy link
Collaborator

So I understand the "Total" for rows, but do we need a total for columns at all? That's not really a common/relevant thing to be counted in a table or spreadsheet, which also causes this confusion.

@jancborchardt @AndyScherzinger I would say it is relevant. There is no other way to get the number of columns. Specially when you have a ton of columns, you don't like to count them one by one?! And in the table it might help to get an idea how many columns exists in comparison of the numbers for the views. That way you can easily see if a view contains all columns or how many are missing.

So I would like to keep them, but maybe we can make it more clear what this number means?

@jancborchardt
Copy link
Member

That way you can easily see if a view contains all columns or how many are missing.

But this also becomes a calculation you have to do on your own, especially when you have a ton of columns.

I would say this info is not 100% relevant for this overview, but rather in the vuew itself – where it is visible via the modal which columns are enabled or not.

@enjeck
Copy link
Contributor

enjeck commented Feb 16, 2024

Related: #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants