fix: use actual providerId in link rows #1443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
enjeck
commented
Nov 7, 2024
| @@ -38,7 +38,7 @@ public function parseValue($value, ?Column $column = null): string { | |||
| return json_encode(json_encode([ | |||
| 'title' => $data['title'] ?? $data['resourceUrl'], | |||
| 'value' => $data['resourceUrl'], | |||
| 'providerId' => 'url', | |||
| 'providerId' => isset($data['providerId']) ? $data['providerId'] : 'url', | |||
There was a problem hiding this comment.
Dunno if there's a reason why 'url' was hardcoded here instead of just using the providerId like this 🤔
There was a problem hiding this comment.
Originates from #779
Does line 30 needs treatment as well?
Shorthand should also do:
Suggested change
| 'providerId' => isset($data['providerId']) ? $data['providerId'] : 'url', | |
| 'providerId' => $data['providerId'] ?? 'url', |
whaever
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1442
Before
Screencast.from.11-07-2024.03_32_38.AM.mp4
After
Screencast.from.11-07-2024.03_31_51.AM.mp4
TODO: