Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the userId configurable for the analytics data provider to use #508

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

datenangebot
Copy link
Collaborator

closes #464

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment regarding the constructor, otherwise seems good

lib/Api/V1Api.php Outdated Show resolved Hide resolved
lib/Api/V1Api.php Outdated Show resolved Hide resolved
Florian Steffens and others added 3 commits September 12, 2023 10:24
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Florian <florian.steffens@nextcloud.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Florian <florian.steffens@nextcloud.com>
@datenangebot datenangebot force-pushed the fix/464-analytics-integration branch from 17e98ed to 26f1414 Compare September 12, 2023 08:24
@datenangebot datenangebot marked this pull request as ready for review September 12, 2023 08:24
@datenangebot datenangebot merged commit 32d1f4f into main Sep 12, 2023
14 of 15 checks passed
@datenangebot datenangebot deleted the fix/464-analytics-integration branch September 12, 2023 09:01
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnalyticsDatasource error on 0.6.0-beta.1
2 participants