Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @nextcloud/dialogs to v5 #627

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 21, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/dialogs ^4.2.1 -> ^5.0.0-beta.6 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-dialogs (@​nextcloud/dialogs)

v5.0.0-beta.6

Compare Source

Full Changelog

💥 Breaking changes

The FilePicker Vue component is no longer exported in the main entry point.
Instead it is exported in a filepicker entrypoint, and the FilePicker builder is also now loading it async. This ensures that if a user does not use the filepicker, it gets treeshaken.

🚀 Enhancement
🐛 Fixed bugs
Changed
🤖 Dependency updates

v5.0.0-beta.5

Compare Source

Full Changelog

🐛 Fixed bugs
  • fix: breadcrumbs grow #​987 (skjnldsv)
  • Fix alignment of file list #​993 (susnux)
  • fix(FilePicker): Use search function from webdav package instead of workaround #​992 (susnux)
  • fix(FilePicker): Ensure file list header is shown on top of scrolled content rows #​997 (susnux)
🤖 Dependency updates

v5.0.0-beta.4

Compare Source

Full Changelog

🐛 Fixed bugs
  • fix(FilePicker): Reset selected files if the current directory is changed #​964 (susnux)
  • Revert "fix: Patch webdav dependency for invalid exports field un… #​984 (skjnldsv)

v5.0.0-beta.3

Compare Source

Full Changelog

🐛 Fixed bugs
  • fix: Make file list only sortable by one property at the time #​949 (susnux)
  • fix: styling issues and make the FilePicker height fixed #​971 (susnux)
  • fix: Use core preview controller for loading file previews and fallback to MDI icons #​962 (susnux)
  • fix(FilePicker): Fix selecting rows using the keyboard #​934 (susnux)
  • fix(FilePicker): Only show checkbox skeletons if multiselect was enabled #​969 (susnux)
  • fix(FilePickerBuilder): Fix paths returned in Promise by pick method #​963 (susnux)
  • fix(NcDialog): Make the heading always center aligned on top #​965 (susnux) (susnux)
🚀 Enhancement
  • feat(FilePickerBuilder): Allow to configure the dialog container element #​950 (susnux)
🤖 Dependency updates
  • chore: Update @nextcloud/files version #​952 (susnux)
  • chore(deps): Bump @​nextcloud/files from 3.0.0-beta.19 to 3.0.0-beta.21
  • chore(deps): Bump @​nextcloud/vue from 8.0.0-beta.3 to 8.0.0-beta.5
  • chore(deps): Bump webdav from 5.2.3 to 5.3.0

v5.0.0-beta.2

Compare Source

Full Changelog

🚀 Enhancement
  • feat: Add icons for filepicker and allow reactive button based on current path and selection #​938 (susnux)
  • feat(FilePicker): Always show file extension as a trailing text part #​931 (susnux)
  • Add empty content when there are no files #​930 (susnux)
🐛 Fixed bugs
  • fix: The file list should be showed when files are loading #​937 (susnux)
  • fix(FilePicker): Ensure focus-visible outline is visible for all focusable elements #​935 (susnux)
  • fix(FilePicker): Do not show checkboxes on single select mode #​929 (susnux)
  • fix: Add missing defaults to DialogButton #​927 (susnux)
  • fix(FilePickerBuilder): Revert API change on pick() #​925 (susnux)
  • fix(FilePicker): The table height should be max. 100% #​921 (susnux)
Changed

v5.0.0-beta.1

Compare Source

💥 Breaking
  • A Vue based file picker is provided which uses @nextcloud/vue version 8, so this library will only work on Nextcloud 28+
  • Modernize FilePickerBuilder to directly make use of the Vue based file picker #​904 (@​susnux)
    • This slightly breaks the FilePickerBuilder API:
      • FilePicker.pick now returns a Promise resolving to string[] containing the picked paths
      • FilePicker.constructor parameter order was changed
      • FilePickerBuilder.setModal was removed as it has no effect
      • FilePickerBuilder.setType is deprecated in favor of FilePickerBuilder.addButton
      • FilePickerBuilder.addButton was added which allows to add custom buttons with callbacks on click (so users can now distinguish which button was clicked)
🚀 Enhancement
  • A Vue based FilePicker component was added, which can be used either as a component or using programmatically #​878 (@​susnux)
  • FilePickerBuilder: Allow to add custom buttons #​896 (@​susnux)
🐛 Fixed bugs
Changed
  • The package does no longer contain core-js polyfills as Nextcloud core already provides polyfills #​863 (@​susnux)
  • The project was moved to a new Github organization (nextcloud-libraries)
  • Add version compatibility section to README #​891 (@​susnux)
  • Improved developer documentation #​906 (@​susnux)
  • Dependency updates

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 21, 2023
@renovate renovate bot requested review from a team, blizzz and office-team-bot and removed request for a team October 21, 2023 04:08
@renovate
Copy link
Contributor Author

renovate bot commented Oct 21, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: tables@0.6.0
npm ERR! Found: @nextcloud/vue@7.12.6
npm ERR! node_modules/@nextcloud/vue
npm ERR!   @nextcloud/vue@"^7.12.6" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @nextcloud/vue@"^8.0.0-beta.8" from @nextcloud/dialogs@5.0.0-beta.6
npm ERR! node_modules/@nextcloud/dialogs
npm ERR!   @nextcloud/dialogs@"^5.0.0-beta.6" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/worker/cf8a2b/3709f2/cache/others/npm/_logs/2023-10-21T04_08_19_457Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/worker/cf8a2b/3709f2/cache/others/npm/_logs/2023-10-21T04_08_19_457Z-debug-0.log

@renovate renovate bot changed the title Update dependency @nextcloud/dialogs to v5 fix(deps): update dependency @nextcloud/dialogs to v5 Oct 26, 2023
@juliusknorr
Copy link
Member

Needs to wait until we match with upstream version requirements:

Screenshot 2023-11-02 at 11 22 04

@juliusknorr juliusknorr closed this Nov 2, 2023
Copy link
Contributor Author

renovate bot commented Nov 2, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/nextcloud-dialogs-5.x branch November 2, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant