Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hide user status from owner avatar (issue #829) #853

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Feb 16, 2024

Status icon removed from navigation sidebar as illustrated in issue #829

image

Also removed from other places which I thought were not needed, such as next to the table title, the share list when sharing the table, and the views dashboard:

image
image
image

If these additional changes are unnecessary or should not have been changed, it can easily be rolled back to only remove the icon from the navigation sidebar as shown in the original issue.

Elizabeth Danzberger added 2 commits February 16, 2024 12:57
Signed-off-by: Elizabeth Danzberger <spookystuff@protonmail.com>
Signed-off-by: Elizabeth Danzberger <spookystuff@protonmail.com>
@elzody elzody requested a review from juliusknorr February 16, 2024 19:02
@elzody elzody linked an issue Feb 16, 2024 that may be closed by this pull request
@juliusknorr juliusknorr requested a review from enjeck February 19, 2024 11:08
@juliusknorr
Copy link
Member

Adjusting other places seems fine, just the share recipients i think it would make sense to keep the status to be consistent with other sharing sidebars (like in files) where we also show the status. Maybe you can just drop that commit.

@elzody
Copy link
Contributor Author

elzody commented Feb 19, 2024

@jancborchardt Curious to know some designer feedback on this

Signed-off-by: Elizabeth Danzberger <spookystuff@protonmail.com>
@elzody
Copy link
Contributor Author

elzody commented Feb 19, 2024

Adjusting other places seems fine, just the share recipients i think it would make sense to keep the status to be consistent with other sharing sidebars (like in files) where we also show the status. Maybe you can just drop that commit.

I think I managed to drop that commit, hopefully I did it correctly without messing anything up :)

@juliusknorr juliusknorr added 3. to review Waiting for reviews bug Something isn't working labels Feb 19, 2024
@juliusknorr
Copy link
Member

Looks like that worked fine ;)

@juliusknorr juliusknorr added this to the v0.7.0 milestone Feb 19, 2024
@juliusknorr juliusknorr merged commit caa8f36 into main Feb 20, 2024
41 checks passed
@juliusknorr juliusknorr deleted the fix/829 branch February 20, 2024 09:33
Copy link
Contributor

github-actions bot commented Mar 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide user status from owner avatar
2 participants