Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter returned entity result by view columns #881

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 29, 2024

When updating rows in a view I noticed a but where the second update operation of the same row wold fail in the frontend.

It turned out that the first update would actually return a column that was not in the view itself which it tried to update then on the next attempt.

This PR introduces filtering for the actual columns of a view in places where we return its data (update/delete).

Steps to reproduce:

  • Create a table with some entries
  • Create a view that hides one table column
  • Open the view and edit a row twice

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from blizzz and elzody February 29, 2024 07:05
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Feb 29, 2024
@juliusknorr juliusknorr merged commit a11cfa0 into main Feb 29, 2024
50 checks passed
@juliusknorr juliusknorr deleted the fix/view-update-delete branch February 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants