Feat: File action to import from Files to Tables

[elzody]

Related Issue

This feature is in response to issue #365

Explanation

This feature adds a file action to files in the Files app, which allows you to import the file into Tables, provided it is a supported file format. Upon clicking the "Import into Tables" button in the file action menu, a dialog will be displayed which lets you choose to import the data as a new table, or if you want to import the data into an existing table.

Importing the data as a new table allows you to choose an icon and a name for the table, and if none are provided, will use the 🔧 icon and the file name for the table information. If you choose to import the file into an already existing table, it allows you to select one of your tables and gives you the choice of creating missing columns or not. *

* Possible bug with this, will look into it

Screenshots

File action

Import dialog

Import results dialog

TODO

• Look into better way of including the Tables icon in the file action than hardcoding the SVG string
• Because 2 new components were added, look into maybe the re-usability of these, particularly the import results dialog?
• No testing yet, so this would probably be a good thing to include at some point
• Instead of passing t function for translation to the modal, can probably just import it itself (just realized this was a thing)
• Implement better error handling / error feedback for the user
• There seems to be a residual commit that is unrelated to this PR; it should be dropped

Follow up

• Fix potential issue with importing into an existing table when the "Create missing columns" toggle is disabled
• Upon mounting the import dialog component, the user's tables are retrieved from the backend. Look into ways to cache this and reduce number of network requests.

[juliusknorr]

A few comments, only read the code so far, haven't tried it yet

[juliusknorr]

When wrapping up, would also be nice to squash commits in a meaningful way a bit if possible or just all in one feature commit which makes the history once merged a bit clearer. Also I haven't mentioned before and we don't enforce this, but most of us try to somewhat stick to conventional commits https://www.conventionalcommits.org/en/v1.0.0/ Might be nice to adapt that as well ;)

[juliusknorr]

Just two comments, otherwise this looks good 👍

[juliusknorr]

Just pushed two small fixups when trying out locally. First one for cypress, second adding the missing dependencies

[juliusknorr]

The new files api only works with 28 so we just just skip the cypress tests on earlier versions.

[juliusknorr]

We can just pass in the server version as collectives does in the cypress.yml github workflow:

CYPRESS_ncVersion: ${{ matrix.server-versions }}

Then we can skip the tests in the spec files

102:			if (['stable26', 'stable27'].includes(Cypress.env('ncVersion'))) {

[juliusknorr]

Rebased, squashed and pushed a small follow up fix. I noticed that the tests seemed to fail only sometimes where the file action was not showing up. This might happen if the files app code initializes before the action was registered, so I moved the script loading to be earlier

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!