Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make text in preview selectable, so that user can copy it #3336

Merged
merged 1 commit into from
Sep 29, 2023
Merged

make text in preview selectable, so that user can copy it #3336

merged 1 commit into from
Sep 29, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 22, 2023 •
edited
Loading

Needs testing, currently in train and no local docker 😇

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@tobiasKaminsky @mahibi
make text in preview selectable, so that user can copy it
5af4c72 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@mahibi mahibi added this to the 17.2.0 milestone Sep 29, 2023
@mahibi mahibi merged commit f385326 into master Sep 29, 2023
14 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the txt branch September 29, 2023 09:37
@mahibi
Copy link
Collaborator

mahibi commented Sep 29, 2023

works.
thx

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3336-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9191
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @mahibi