-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error 429 "Too Many Requests" is now handled #3342
Conversation
ncApi.setUserData is not the method that needs the 'Too many requests' handling but |
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
1f305ad
to
79af073
Compare
createLinkedAccounts(contactsWithAssociatedPhoneNumbers) | ||
when (foundContacts.ocs?.meta?.statusCode) { | ||
HTTP_CODE_TOO_MANY_REQUESTS -> { | ||
Toast.makeText( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me to use a toast here as we have no view.
just an edge case here which might never(?) be triggered..
otherwise we prefer snackbar
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3342-talk.apk |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
🏁 Checklist
/backport to stable-xx.x