Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 429 "Too Many Requests" is now handled #3342

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 25, 2023

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 changed the title Handling 429 is now handled Error 429 "Too Many Requests" is now handled Sep 25, 2023
@AndyScherzinger AndyScherzinger added this to the 17.2.0 milestone Sep 27, 2023
@mahibi
Copy link
Collaborator

mahibi commented Sep 27, 2023

ncApi.setUserData is not the method that needs the 'Too many requests' handling but
ncApi.searchContactsByPhoneNumber in ContactAddressBookWorker.

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi mahibi force-pushed the issue-3340-phonebook-sync-info branch from 1f305ad to 79af073 Compare September 29, 2023 08:30
@mahibi mahibi merged commit fd643da into master Sep 29, 2023
10 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-3340-phonebook-sync-info branch September 29, 2023 08:31
createLinkedAccounts(contactsWithAssociatedPhoneNumbers)
when (foundContacts.ocs?.meta?.statusCode) {
HTTP_CODE_TOO_MANY_REQUESTS -> {
Toast.makeText(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me to use a toast here as we have no view.
just an edge case here which might never(?) be triggered..
otherwise we prefer snackbar

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9191
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3342-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle '429 Too Many Requests' for phonebook sync
3 participants