Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for accept call message #3357

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 3, 2023

🖼️ Screenshots

Context on a OnePlus 9 Pro
image

Replicated in IDE

🏚️ Before 🏡 After
image 2023-10-04 11_29_19-talk-android-fix_accept_call_button_reformating – call_started_message xml  talk

Note: the profile picture also didn't load in the image. I think by setting the request size to small, this changed, but I'll need to test it some more to be sure. For now I also set the default profile to the account_circle_48dp

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added bug Something isn't working 3. to review Waiting for reviews labels Oct 3, 2023
@rapterjet2004 rapterjet2004 self-assigned this Oct 3, 2023
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Signed-off-by: Julius Linus <julius.linus@nextcloud.com>
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@AndyScherzinger AndyScherzinger force-pushed the bug_fix_accept_call_button_reformating branch 2 times, most recently from 660f244 to 95b3d90 Compare October 4, 2023 09:16
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the 17.2.0 milestone Oct 4, 2023
@AndyScherzinger AndyScherzinger force-pushed the bug_fix_accept_call_button_reformating branch from 95b3d90 to eea7c70 Compare October 4, 2023 09:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Codacy

Lint

TypemasterPR
Warnings9191
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3357-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit 86e4d31 into master Oct 4, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bug_fix_accept_call_button_reformating branch October 4, 2023 10:21
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants