Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Clear FLAG_SECURE after passcode screen #4172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parneet-guraya
Copy link
Contributor

@parneet-guraya parneet-guraya commented Sep 9, 2024

Fixes
#4164
#4076

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 9, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4172-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Codacy

Lint

TypemasterPR
Warnings8692
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@mahibi
Copy link
Collaborator

mahibi commented Sep 10, 2024

i just saw by coincidence the PR #3716 from @sowjanyakch that introduced the
|| appPreferences.isScreenLocked

@sowjanyakch can you summarize why this was done?

@sowjanyakch
Copy link
Contributor

PR #3716 introduced
|| appPreferences.isScreenLocked
to hide the screen contents from recents screen when screen lock is enabled. However, this created an issue #4076. @parneet-guraya can you try to fix #4076 without breaking the feature hiding screen contents from recents screen?

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants