Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting #4502

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix formatting #4502

wants to merge 5 commits into from
+25 −39

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Nov 29, 2024 •
edited
Loading

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Nov 29, 2024
@AndyScherzinger
style(ktlint): Fix formatting
1849d05 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(detekt): Improve score
192d74d 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@mahibi mahibi self-requested a review November 29, 2024 11:38
tobiasKaminsky and others added 2 commits November 29, 2024 13:15
@tobiasKaminsky
make lint pass for now
47050d3 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger
style(lint): make use of ResourceCompat
caf9719 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4502-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Analysis: update lint results to reflect reduced error/warning count
066a683 
Signed-off-by: github-actions <github-actions@github.com>
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94158
Errors13273

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews technical debt Technical issue and removed 2. developing Work in progress labels Nov 29, 2024
@AndyScherzinger AndyScherzinger modified the milestones: 21.0.0, 20.1.0 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi Awaiting requested review from mahibi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @tobiasKaminsky