From aa18f5046b61963ed0bba6a074c9b3b38704b0fa Mon Sep 17 00:00:00 2001 From: "Grigorii K. Shartsev" Date: Fri, 12 Jan 2024 05:57:53 +0100 Subject: [PATCH] fix(menubar): remove incorrect `aria-activedescendant` - `aria-activedescendant` should identify a visually focused element when the real focus remains on this element. In the current implementation it identified selected element (even when the menu is closed), not the focused. - `aria-activedescendant` is not needed because NcAction has actual focus anyway. In case it will be actually needed, it should be implemented in the `NcActions` Signed-off-by: Grigorii K. Shartsev --- src/components/Menu/ActionList.vue | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/components/Menu/ActionList.vue b/src/components/Menu/ActionList.vue index d9455fc86cb..5cc77144cb1 100644 --- a/src/components/Menu/ActionList.vue +++ b/src/components/Menu/ActionList.vue @@ -27,7 +27,6 @@ :container="menuIDSelector" :aria-label="labelWithSelected" :type="state.active ? 'primary': 'tertiary'" - :aria-activedescendant="currentChild ? `${$menuID}-child-${currentChild.key}` : null" :force-menu="true" :name="labelWithSelected" :data-text-action-entry="actionEntry.key" @@ -37,7 +36,6 @@