Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich workspaces: move formatting bar in front of breadcrumbs #2234

Open
ya-d opened this issue Jan 27, 2022 · 6 comments
Open

Rich workspaces: move formatting bar in front of breadcrumbs #2234

ya-d opened this issue Jan 27, 2022 · 6 comments
Labels
design Experience, interaction, interface, … enhancement New feature or request feature: rich workspaces

Comments

@ya-d
Copy link

ya-d commented Jan 27, 2022

Is your feature request related to a problem? Please describe.
The rich workspaces feature adds a lot of unnecessary whitespace in the Files app as it reserves a vertical bar for formatting options – even if editing isn’t active or even if there is no readme at all.

If you enter the rich text area the whitespace is used to show the formatting bar. Which is again faded out if you exit text editing.

Describe the solution you'd like
As the formatting bar is only displayed if you actively click into the rich text area, I propose to move the formatting bar in front of folder breadcrumbs. Additionally a close button could be shown where the view switch is located.

If you exit the editing mode by clicking anywhere or using the close button, breadcrumbs are back there to navigate folders.

Describe alternatives you've considered
You can completely turn off rich workspaces but that strips the feature entirely not only the whitespace.

Quick mockups
Current:
rich1
rich2
Proposal:
rich4
rich3

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@ya-d ya-d added 0. Needs triage enhancement New feature or request labels Jan 27, 2022
@szaimen szaimen transferred this issue from nextcloud/server Mar 12, 2022
@juliusknorr
Copy link
Member

Might be tricky to implement properly from a technical perspective, as currently the styling is quite simple with being limited to the container div, but UI wise let's see what @nimishavijay and @jancborchardt think.

@juliusknorr
Copy link
Member

@jancborchardt Any feedback on this one?

@juliusknorr
Copy link
Member

🏓 @nextcloud/designers

@marcoambrosini
Copy link
Member

I think we should use a formatting bar here (and everywhere else) like notion does

nextcloud-libraries/nextcloud-vue#4355

@juliusknorr
Copy link
Member

We had a floating menu in the past for inserting links / updating links but it was not discoverable to lots of users and caused major troubles with mobile devices, especially on conflicting with native mobile browser dialogs on selected text, so this is something I would not re-introduce in text.

@nimishavijay
Copy link
Member

Agreed with Julius, a floating formatting bar works in theory, but there were many issues even just for formatting links.

Since the problem is about the extra whitespace (which I agree with), what if we have the following behavior:

  • when the rich workspace is not focused, remove that whitespace (so the height of that area will be lesser than it is currently)
  • on focus there is an increase in height of the rich workspace area and the formatting bar is shown
  • a transition/animation to smooth out the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Experience, interaction, interface, … enhancement New feature or request feature: rich workspaces
Projects
None yet
Development

No branches or pull requests

7 participants