Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide rich workspace header when there is no Readme.md #4541

Closed
lukas-schaetzle opened this issue Jul 17, 2023 · 3 comments · Fixed by #4771
Closed

Hide rich workspace header when there is no Readme.md #4541

lukas-schaetzle opened this issue Jul 17, 2023 · 3 comments · Fixed by #4771
Assignees
Labels
3. to review bug Something isn't working

Comments

@lukas-schaetzle
Copy link

lukas-schaetzle commented Jul 17, 2023

Apparently, this issue has already been fixed some time ago (#3209) but seems to have re-emerged (even though now, it only shows whitespace instead of the hint "add notes...").

  • Nextcloud 26.0.3
  • NC Text 3.7.2
  • Tested with latest versions of Firefox and Chrome.

grafik

A quick glance in the dom revealed that the whitespace container is indeed the rich text workspace. Disabling the text extension also removes the whitespace.

grafik

@lukas-schaetzle lukas-schaetzle added the bug Something isn't working label Jul 17, 2023
@juliusknorr
Copy link
Member

Seems to be caused by 4d2f4fe#diff-71632b16584c065ab42128d2b5d2d631bcf9512fd807a794529b9518a56a6793R206 still

For now i think we should just remove the height when no workspace is shown, a proper follow up would be #4254 (comment)

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jul 17, 2023
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jul 17, 2023
@luka-nextcloud luka-nextcloud moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Sep 6, 2023
@lukas-schaetzle
Copy link
Author

Just downloaded NC 27.1.0 with Text 3.8.0 but the ui issue is still there. Please reopen.

@mejo-
Copy link
Member

mejo- commented Sep 21, 2023

@tummerhore this only got fixed in the main branch so far, which will become Nextcloud 28. I agree that we should backport this to Nextcloud 27 and 26 though. @luka-nextcloud could you take care of this?

Edit: I just requested the backport myself ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants