Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant synchronous task handling and polishing #4686

Closed
8 tasks
juliusknorr opened this issue Aug 16, 2023 · 5 comments · Fixed by #5269
Closed
8 tasks

Assistant synchronous task handling and polishing #4686

juliusknorr opened this issue Aug 16, 2023 · 5 comments · Fixed by #5269
Assignees
Labels

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Aug 16, 2023

from #4627

  • Implement synchronous tasks
  • Smaller polishing
    • use notifications for triggering fetch instead of polling
    • FAB on mobile
    • How to handle markdown vs plain text
    • Dismiss notifications
    • merge translate to it and just move the actions to popover directly
    • Think about the making it show/hide depending on the mouse cursor (gdocs)
@juliusknorr juliusknorr added the bug Something isn't working label Aug 16, 2023
@julien-nc
Copy link
Member

julien-nc commented Nov 20, 2023

Additionally:

  • Decide what to do when the assistant returns a completed task immediately (new sync flow).

@juliusknorr
Copy link
Member Author

As discussed in the call

  • Assistant will offer a flag to close the modal after a successful sync task
    • Can be used to directly insert and act with a sync result in text (e.g. when generating text on an empty line)
    • If a task is switched from sync to async the promise resolves as usual with the task but the info about the scheduled task is shown no matter if the close modal flag is set or not
  • The main promise always resolves the task with its current status
  • There will be a list of action buttons that can be provided through the openAssistantForm parameters
    • Can be used in text to offer insert/replace actions on the result screen

@juliusknorr juliusknorr moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 21, 2023
@juliusknorr juliusknorr changed the title Assistant follow ups Assistant synchronous task handling and polishing Dec 21, 2023
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Dec 21, 2023
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Jan 4, 2024
@jancborchardt
Copy link
Member

If there are any design questions regarding this, @nimishavijay is the expert since she worked on the current implementation. :)

@luka-nextcloud luka-nextcloud moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jan 4, 2024
@luka-nextcloud
Copy link
Contributor

As discussed in the call

  • Assistant will offer a flag to close the modal after a successful sync task

    • Can be used to directly insert and act with a sync result in text (e.g. when generating text on an empty line)
    • If a task is switched from sync to async the promise resolves as usual with the task but the info about the scheduled task is shown no matter if the close modal flag is set or not
  • The main promise always resolves the task with its current status

  • There will be a list of action buttons that can be provided through the openAssistantForm parameters

    • Can be used in text to offer insert/replace actions on the result screen

@juliushaertl I have checked the repo Assistant app but seems like it still does not provide these functions:

  • There is no event or public function to close the modal after a successful sync task
  • There are no parameters for a list of action buttons that can be provided through the openAssistantForm parameters

@juliusknorr
Copy link
Member Author

I linked the wrong PR but the main branch should have both https://github.com/nextcloud/assistant/blob/main/src/assistant.js#L37-L44

Reference PR nextcloud/assistant#18

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Feb 28, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants