Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect - dialogues and errors appearing repeatedly despite reconnection #5134

Closed
gerbrent opened this issue Dec 15, 2023 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@gerbrent
Copy link

Describe the bug

  • The reconnect dialogue appears if, say, a document has been in edit mode and one's computer had been off for an extended period of time.
  • Then, if Reconnect button is clicked, the system appears to reconnect.
  • Only after a few seconds, connection errors appear (Connection failed.) and the reconnect button reappears, only to vanish again and repeat the cycle indefinitely every 3-4 seconds.

May be related to #4943 ?

To Reproduce
Steps to reproduce the behavior:

  1. open and .md document for editing (in browser).
  2. Keep the doc open, the move offline for extended period of time. (i.e. computer sleep)
  3. Move online (i.e. unsleep/wake computer)
  4. See Reconnect error w Reconnect button (expected behaviour!)
  5. Click Reconnect button
  6. Have error messages and Reconnect button reappear every 3-4 seconds indefinitely.

Expected behavior
Editor reconnects, and errors do not persist/reappear.

Screenshots
Peek 2023-12-15 14-34 - edit gif

Server details:

  • Nextcloud version: 28.0.0
  • PHP Version: 🤷
  • Database: 🤷

Client details:

  • OS: NixOS
  • Browser: Firefox 120.0.1
  • Browser version: 120.0.1
  • Device: desktop
Logs

Nextcloud log (data/nextcloud.log)

Browser log

Uncaught (in promise) Error: Close has already been called on the connection
    C SessionApi.js:28
    I SessionApi.js:183
    close SessionApi.js:176
    _close SyncService.js:295
    close SyncService.js:287
    close WebSocketPolyfill.js:120
    _checkInterval y-websocket.js:374
    r NextJS
SessionApi.js:28:2
[ERROR] text: Unexpected Error "Failed to apply steps. Retry!"
Object { app: "text", uid: "brent", level: 2, error: Error }
sentry.js:2:63997
Uncaught (in promise) Error: Close has already been called on the connection
    C SessionApi.js:28
    I SessionApi.js:183
    close SessionApi.js:176
    _close SyncService.js:295
    close SyncService.js:287
    close WebSocketPolyfill.js:120
    _checkInterval y-websocket.js:374
    r NextJS
SessionApi.js:28:2
Uncaught (in promise) Error: Close has already been called on the connection
    C SessionApi.js:28
    I SessionApi.js:183
    close SessionApi.js:176
    _close SyncService.js:295
    close SyncService.js:287
    close WebSocketPolyfill.js:120
    _checkInterval y-websocket.js:374
    r NextJS
2 SessionApi.js:28:2
Got notification data, restoring default polling interval. sentry.js:2:63997
Uncaught (in promise) Error: Close has already been called on the connection
    C SessionApi.js:28
    I SessionApi.js:183
    close SessionApi.js:176
    _close SyncService.js:295
    close SyncService.js:287
    close WebSocketPolyfill.js:120
    _checkInterval y-websocket.js:374
    r NextJS
@gerbrent gerbrent added the bug Something isn't working label Dec 15, 2023
@juliusknorr juliusknorr self-assigned this Dec 18, 2023
@juliusknorr
Copy link
Member

Likely the patch mentioned in #5126 (comment) could help here

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 18, 2023
@AdamPS
Copy link

AdamPS commented Dec 22, 2023

I am seeing something that looks very much like this. I see these errors repeating in the browser console.

  • [ERROR] text: Unexpected Error "Failed to apply steps. Retry!"
  • Uncaught (in promise) Error: Close has already been called on the connection

In the worst case the app is unusable.

@AdamPS
Copy link

AdamPS commented Jan 9, 2024

Workaround: hard-refresh the browser (Ctrl+F5) or start a new tab/window

@nicofrand
Copy link
Contributor

I get something similar with the android app and the WebView (rich editor), after switching between apps or after some idle time.

@mejo-
Copy link
Member

mejo- commented Jan 22, 2024

This should have been fixed by #5126. The fix will get released with the upcoming 26.0.11, 27.1.6 and 28.0.2 releases. Please comment and reopen if you still discover the issues after upgrading to one of these versions.

@mejo- mejo- closed this as completed Jan 22, 2024
@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants