Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(eslint): Fix linting javascript files, also lint typescript files #6726

Open
wants to merge 3 commits into
base: stable30
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 2, 2024

Backport of #6725

@backportbot backportbot bot requested review from max-nextcloud and mejo- December 2, 2024 16:36
@backportbot backportbot bot added tests If you write them we ♥ you 3. to review labels Dec 2, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.3 milestone Dec 2, 2024
@mejo- mejo- force-pushed the backport/6725/stable30 branch from 423782e to 00bd7c2 Compare December 2, 2024 16:57
@mejo- mejo- marked this pull request as ready for review December 2, 2024 16:58
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.60%. Comparing base (9a6fda7) to head (e8da521).
Report is 2 commits behind head on stable30.

Additional details and impacted files
@@            Coverage Diff            @@
##           stable30    #6726   +/-   ##
=========================================
  Coverage     53.60%   53.60%           
=========================================
  Files           116      116           
  Lines          2580     2580           
  Branches        524      526    +2     
=========================================
  Hits           1383     1383           
  Misses         1069     1069           
  Partials        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Required to import all Nextcloud eslint rules, not only the typescript
ones.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@juliusknorr juliusknorr force-pushed the backport/6725/stable30 branch from 78c8b88 to e8da521 Compare December 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants