Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Ability to see password in connector configuration #6328

Open
thorst opened this issue Oct 23, 2024 · 3 comments
Open

[IDEA] Ability to see password in connector configuration #6328

thorst opened this issue Oct 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@thorst
Copy link

thorst commented Oct 23, 2024

Is your feature request related to a problem? Please describe.
We save connection information to the configuration map so that we don't hardcode in our scripts. We store a javascript object, then in the deploy script we use JSON.parse to get it back into a js object. Then we would use it in the configuration like ${cred.un} and ${cred.pw} this works fine, but you cannot see the password so your typing blind or copying and pasting it. Just add an icon or button to view the password instead of having it be obscured.

@thorst thorst added the enhancement New feature or request label Oct 23, 2024
@pacmano1
Copy link
Collaborator

pacmano1 commented Oct 23, 2024

I think you mean "option to unmask fields that are masked". Since in your case you just want to see ${cred.pw}, not the password itself, right? ${cred.pw} isn't evaluated until run time.

Also - I would not use $cfg for this. Instead $cfg has only db connect information. Then everything else is sourced to $g or $gc on startup or channel deploy. Already an object in that case. (gonna avoid the entire topic of seeing passwords in the mirth UI, lol)

@thorst
Copy link
Author

thorst commented Oct 23, 2024

Correct. Currently, it's dots, and it would be nice to see the plain text.

As for $cfg, why stop at db connection info when you can store api connection info, or sftp connection info. Ultimately, we do use the channel deploy script to place the values onto the $gc. We do this so that we only have to change the connection information in 1 spot instead of dozens.

@pacmano1
Copy link
Collaborator

pacmano1 commented Oct 23, 2024

What you currently store in $cfg goes to $g:

And you store all that other information you currently store in $cfg into relevant db tables and source it on start to objects accessible to all channels (if needed in $g) or single channels via $gc.

e.g. in a global deploy script populate $g such that anywhere you can reference:

$g('this_client').api_endpoint
$g('this_client').api_username

$g('this_ehr').global_charge_item_id

Nothing wrong with your way of course. I usually think in terms of abstracting this further. e.g. engine starts, it knows it is in test, it knows its db connect string (not mirthdb of course) is X for env test. It goes and gets everything else from the db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants