Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider UI/UX for AWS Batch runtime without Docker runtime #328

Open
joverlee521 opened this issue Nov 8, 2023 · 3 comments
Open

Consider UI/UX for AWS Batch runtime without Docker runtime #328

joverlee521 opened this issue Nov 8, 2023 · 3 comments

Comments

@joverlee521
Copy link
Contributor

We have not considered users who are using the AWS Batch runtime but not the Docker runtime, but it's definitely possible!

I think the main point to consider here is how to manage the image used for AWS Batch. Maybe we should consider adding a nextstrain update aws-batch command that can update the docker image version? Maybe add image to the AWS Batch config section? I think either would add more complexity to #167...

@tsibley
Copy link
Member

tsibley commented Nov 13, 2023

Good to consider this. I think the main decision point is if the AWS Batch runtime image should stay tightly coupled to the Docker runtime image.

If it should, then nextstrain update aws-batch (and nextstrain setup aws-batch) could touch the docker.image config var. But this might be somewhat unintuitive and surprising, as other runtimes are independent of each other.

It would be more consistent to decouple the AWS Batch and Docker runtime images so they can be setup/updated separately. But this would also be a behavioural change which itself may surprise folks who expect them (consciously or not) to be synced.

@tsibley
Copy link
Member

tsibley commented Oct 28, 2024

Steph from WA DOH recently tripped over this. She uses our Conda runtime locally but also our AWS Batch runtime and had previously used our Docker runtime locally so had an old image version in config.

@tsibley
Copy link
Member

tsibley commented Oct 28, 2024

James reports being tripped up by this in the past too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants