Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why did the tarball filename change from nextstrain-cli-VERSION.tar.gz to nextstrain_cli-VERSION.tar.gz from 8.2.0 to 8.3.0 #378

Closed
corneliusroemer opened this issue Jul 4, 2024 · 1 comment
Closed

Why did the tarball filename change from nextstrain-cli-VERSION.tar.gz to nextstrain_cli-VERSION.tar.gz from 8.2.0 to 8.3.0 #378

corneliusroemer opened this issue Jul 4, 2024 · 1 comment
Labels
question Question about the project

Comments

@corneliusroemer
Copy link
Member

The bioconda recipe expects the hyphenated version. The underscore one doesn't work, so we haven't gotten versions 8.3.0 and following in bioconda.

I couldn't find out why the tarball name changed. Any clues?
@corneliusroemer corneliusroemer added bug Something isn't working question Question about the project and removed bug Something isn't working labels Jul 4, 2024
@corneliusroemer corneliusroemer changed the title Why did the tarball filename change from nextstrain-cli-VERSIOn.tar.gz to nextstrain_cli-VERSION.tar.gz from 8.2.0 to 8.3.0 Why did the tarball filename change from nextstrain-cli-VERSION.tar.gz to nextstrain_cli-VERSION.tar.gz from 8.2.0 to 8.3.0 Jul 4, 2024
@corneliusroemer
Copy link
Member Author

I think I figured it out:
pypa/setuptools#4159

setuptools wrongly turned underscore into hyphen. We had set up the recipe relying on this bug.

The bug was fixed, so now things break.

Hard to track down because we don't pin setuptools, but always upgrade to latest version when releasing.

@corneliusroemer corneliusroemer mentioned this issue Jul 5, 2024
Open
@tsibley tsibley closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Question about the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsibley @corneliusroemer