Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send error logs to Slack #408

Open
joverlee521 opened this issue Jun 28, 2023 · 0 comments
Open

Send error logs to Slack #408

joverlee521 opened this issue Jun 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Context

Requested by @corneliusroemer as a a convenient way to inspect the build logs when the build fails on AWS batch.

Possible solution

According to the Snakemake docs, the onerror handler has access to the log variable which points to the Snakemake log file. This log file only contains the high level info on which rule failed but does not include the stdout/stderr of the scripts of the rule. If the rule has a log file, then using the command line option --show-failed-logs will include the rule's log file in the Snakemake log file. This will require us to add a log file for every rule in the workflow to ensure that we capture any potential error outputs.

Another option is to do this outside of Snakemake. We could send the logs from the nextstrain build command to Slack, but this would require the GitHub Action workflow to stay attached to the AWS Batch job (as discussed recently in a separate PR) or we do some additional wiring to trigger another GH Action workflow in the onerror handler that would re-attach to the failed job and send logs.

Finally, I wanted to surface the recent discussions of implementing a monitoring system/dashboard that would probably minimize the need for sending logs to Slack.

@joverlee521 joverlee521 added the enhancement New feature or request label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

1 participant