-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Suffolk" in lat_longs.tsv
points to somewhere unexpected
#155
Labels
bug
Something isn't working
Comments
Thank you for reporting this issue @fanninpm! Looks like the current Suffolk lat/long points to the same coordinates as the Suffolk County MA lat/long. Looking at the commit history (90cbd77), the seasonal-flu lat_long.tsv was copied over from the ncov/defaults/lat_longs.tsv so we'll need to fix both entries. |
joverlee521
added a commit
that referenced
this issue
Feb 27, 2024
Fixes #155 Interestingly, we don't have any entries for "Suffolk" in the fauna/source-data/geo_synonyms.tsv¹ and I couldn't find any metadata in our private S3 bucket that includes "Suffolk" as a location. ¹ https://github.com/nextstrain/fauna/blob/75e309e9afe2cc97fb56d7a24e22a07b698805bf/source-data/geo_synonyms.tsv
1 task
joverlee521
added a commit
to nextstrain/ncov
that referenced
this issue
Feb 27, 2024
Prompted by nextstrain/seasonal-flu#155. The "Suffolk" location should be the location in UK based on ncov-ingest/source-data/gisaid_geoLocationRules.tsv¹ since all other "Suffolk" entries are corrected to "Suffolk County". ¹ https://github.com/nextstrain/ncov-ingest/blob/d3fa3b990ea417e3188537e1125f032169e55b69/source-data/gisaid_geoLocationRules.tsv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
In the
lat_longs.tsv
file, Suffolk points to somewhere in Boston Harbor.Expected behavior
"Suffolk" should point to somewhere in the East of England/East Anglia, not too far from "Norfolk", "Essex", and "Cambridgeshire".
How to reproduce
Steps to reproduce the current behavior:
Possible solution
I don't know enough about how Nextstrain divides the UK in its
lat_longs.tsv
file to give directions for a possible solution. However, I think this may indicate a broader issue as for the structure of thelat_longs.tsv
file itself. Perhaps there should be more hierarchy in that file, which would answer additional questions such as "Should Hawaii'sregion
value be 'Oceania' (because it's out in the middle of the Pacific) or 'North America' (because it's part of the USA)?".Additional context
For my purposes, I will use "Suffolk ENG" as my
location
value in my metadata.The text was updated successfully, but these errors were encountered: