-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update module_name filter step #7106
base: master
Are you sure you want to change the base?
Conversation
701fd07
to
f75b3fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now only tested the script in isolation, but the test cases pass for me locally as well. Thanks for the solid work!
Looking at the CI failure in this PR...can it be that it was only the missing bracket in the .map() function that caused all the issues?
|
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
This would've broken something
9711ad4
to
b016c5a
Compare
- Added detailed debug logging in get_module_path.js to trace input processing and error handling. - Updated lint.yml to log raw and parsed module files, as well as the result from the script execution. These changes improve visibility into the workflow's operation and facilitate troubleshooting.
Modified the conditional statement in the lint.yml workflow to ensure it checks for non-empty module files using '&&' instead of '||'. This change enhances the accuracy of the workflow's execution criteria, ensuring it only runs when valid module files are present.
c776fbe
to
ec6e796
Compare
ec6e796
to
a460e24
Compare
- Updated get_module_path.js to ensure proper JSON formatting and added logging for the final output. - Modified lint.yml to parse and log the module names output correctly, improving visibility into the workflow's execution. These changes improve error handling and debugging capabilities in the CI workflow.
8f619f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, that will do. Nice work!
Zizmor nags that steps.module_names.outputs.result
may expand into attacker-controllable code, but I don't really see how that could be exploited, because the inputs must be a valid file path. And in the worst case, nf-core modules lint
is just called with some invalid module.
@@ -1,3 +1,3 @@ | |||
process { | |||
ext.args = { "--proband earlycasualcaiman --father hugelymodelbat --mother slowlycivilbuck --af-tag AF regions" } | |||
ext.args = { "--proband earlycasualcaiman --father hugelymodelbat --mother slowlycivilbuck --af-tag AF regions" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this ended up in the PR, but otherwise that looks good to me.
Created a small test script to prevent re-running into edge-cases and to quickly add new test cases. If we don't hate the idea I think we can wire it up to the javascript file to avoid any copy-paste errors.