Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] display legend (key) of what link (color) is what sources #393

Open
etieng opened this issue Jun 5, 2024 · 9 comments

Comments

@etieng
Copy link

etieng commented Jun 5, 2024

Hi,
I'm setting up Open Web Calendar for a group of NGO which shares their web calendars to get a cross synced view.
It sounds pretty good.
A feature that I'm missing is the ability to display on OWC page the key for the colours used.
I may create a webpage and include OWC in it but it would be a lot of work and the feature may be useful for someone else.

For reference here is the OWC instance :
https://lien.liondor.org/evtspublics

I would like to display a key for the different calendars used.

Thanks for developing such a great tool !


We're using Polar.sh so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work. Fund with Polar
@niccokunzmann
Copy link
Owner

niccokunzmann commented Jun 5, 2024

A feature that I'm missing is the ability to display on OWC page the key for the colours used.

Hi, could you tell me what you mean with the key?

I reported #396 as I was trying to change the name of the events with CSS.

grafik

Could you make a picture that shows what you would like to see?

I just had several questions that would help me to understand how you would find it most useful:

  • Would a legend be helpful?
  • Would it be cool just to have this written below the event when it is clicked?
  • Where would you place the legend?
    • On the same page?
    • Would you press a button to see it?
    • In the about page?
    • When you hover the event as a tool-tip?

@niccokunzmann
Copy link
Owner

See also #120

@etieng
Copy link
Author

etieng commented Jun 8, 2024

#120 is highly related as it could bring a list that match the colour and a calendar name.
I mean key as on a map, the part that explains symbols and colours by text.

Would a legend be helpful?

In this use case yes, because here, different colours mean different calendar sources and so different Venues sharing events.

Would it be cool just to have this written below the event when it is clicked?

It could be enough here (see in the preview)

Where would you place the legend?

Left sidebar is the most common as stated in #120, but would take a lot of space
Having it displayed in the hover tool-tip (like in the preview) would be sufficient
Maybe in the top bar (header) as it is highly visible (like in the preview) but maybe problematic on smartphone view with a lot of calendars.

Preview :
Screenshot_20240608_134816

@niccokunzmann
Copy link
Owner

Hi, thanks, this is possible to do... I guess since other people require filtering, it might be nice to actually add a menu that can be opened. That is the most common practice. Again, one can choose to hide the menu and it might be nice to choose what it contains:

  • calendars
  • about page link
  • choosing another timezone, ...

@niccokunzmann
Copy link
Owner

@etieng, #442 adds a menu like this:

grafik

I hope that this would work for you. I am wondering about how to add the description to the calendar. In the ICS file, you can have a calendar name and a calendar description.

@etieng
Copy link
Author

etieng commented Jul 30, 2024

Hi @niccokunzmann
Thanks for this.
I think this could work for me if in some way it's clear that we can click on "calendars" : opened while landing by example or with a burger menu logo or click to expand arrow.

@niccokunzmann
Copy link
Owner

niccokunzmann commented Aug 6, 2024

@etieng, that makes sense! Thinking ahead, I would like to create customization for the menu:

  • filter/display calendars
  • calendar description
  • filter by tags
  • tag description
  • calendar description in general
  • subscribe link

All of these could be added to a menu. Adding a new button for all of them to the calendar is way too much.

To close this:

  • create a menu with a burger
  • open an overlay window Example Menu
  • list the calendars
  • color the calendars
  • allow closing the menu
  • use summary/details to show calendar description

@etieng Do you have feedback on the plan of how I would like to go ahead? I personally like this: Example Menu, also because it is customizable :)

Behind the Scenes: DHTMLX has added a new way to customize colors with CSS variables. Refactoring this would be key to reduce development overhead.

@etieng
Copy link
Author

etieng commented Aug 6, 2024

Reading you, it definitely brings my though to the sidebar and #120 again.
Because thinking to accessibility :

  • adding a layer could be harder to understand (where my calendar is gone ?)
  • that's how it's shown in a lot of other tools (every other ?)

I also really like the fact that OWC is really KISS :

  • a tools to present a view of multiple shared calendars
  • the ability of not giving customizing options to final users is important for me.

But you may still want to go with an expandable side menu ;-)

@niccokunzmann
Copy link
Owner

niccokunzmann commented Aug 6, 2024

Hm. True... Ok that is an other issue... I had a look at your picture again. I believe that that is possible to do. What I was wondering about is the mobile view and readability in all different screen sizes. I am not such a styling expert but I can implement it imperfectly and wait for feedback. I got confused because of the other issues that line up and definitely: What I proposed is more suited to solve other issues and not this one specifically.
Sorry for my confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants