Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter_sets_in_band_present - incorrect failure #11

Open
Lis-TV opened this issue Dec 30, 2022 · 5 comments
Open

parameter_sets_in_band_present - incorrect failure #11

Lis-TV opened this issue Dec 30, 2022 · 5 comments

Comments

@Lis-TV
Copy link

Lis-TV commented Dec 30, 2022

The SequenceParameterSet is present in sample NALU.

@nicholas-fr
Copy link
Owner

As with #12, I'm not sure what is causing this issue as I have been unable to reproduce it unfortunately.

I have added a debug feature to the script.
If you still see this or a similar issue with the latest version of the script, please would you run the script with the --debug option, and share the tcval_logs_date_time.zip that is created, so that I can check how the script may be misinterpreting the ffmpeg/MP4Box logs.

@Lis-TV
Copy link
Author

Lis-TV commented Apr 7, 2023

The output JSON file has:
"test_stream_id": "2",
"test_file_path": "../dpctf-deploy/content/cfhd_sets/12.5_25_50/t2/2022-10-17",
"parameter_sets_in_band_present": {
"expected": true,
"detected": false,
"test_result": "fail"
},

But when I am running
cd ../dpctf-deploy/content/cfhd_sets/12.5_25_50/t2/2022-10-17/1/
cat init.mp4 > a.mp4
cat 0.m4s >> a.mp4
MP4Box -dxml --analyze=bs a.mp4
cat a_dump.xml | grep SequenceParameterSet

I have 5 entities of

NALU size="30" code="7" type="SequenceParameterSet"

So seems the parameter_sets_in_band_present is set incorrectly.

@nicholas-fr
Copy link
Owner

Expected to be the same issue as #12, so if you would please share the JSON results and debug zip (please run the script with --debug), I should be able to find where the parsing of the ffmpeg/MP4Box output is going wrong. Thanks.

@Lis-TV
Copy link
Author

Lis-TV commented Apr 11, 2023

The origin of this issue is different then origin of #12, "analyze=bs" option is not used in MP4Box to check any of: parameter_sets_in_band_present, picture_timing_sei_present, vui_timing_present

@gitwjr
Copy link

gitwjr commented Aug 29, 2023

@nicholas-fr Not blocking release but the validation tool needs updating. Nicholas will review and comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants