Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell rendering? #935

Open
ohaddahan opened this issue May 21, 2018 · 5 comments
Open

Cell rendering? #935

ohaddahan opened this issue May 21, 2018 · 5 comments

Comments

@ohaddahan
Copy link

Is there some hook that will render some HTML code inside the cells?
The aggregators format produce raw text so adding HTML code there didn't work.

The renderes seem pretty massive to write for one simple change like this, any tips?

@nicolaskruchten
Copy link
Owner

There is no way to do this with the built-in renderers for security reasons, so writing your own renderer is the only option :)

See #401

@ohaddahan
Copy link
Author

ohaddahan commented May 22, 2018

Too much details there :)

I'll try to copy an existing one and edit it.
Although, I don't think that adding an option to provide a function that will generate different content is a security issue.

As in something like:

cellRenderer: function(cellValue) { ... }

Don't see it more dangerous than other callbacks we can insert, I mean if I can replace the whole renderer , why not be able to replace only a small portion of it?

@nicolaskruchten
Copy link
Owner

Something like #748 ?

@ohaddahan
Copy link
Author

I think so, is that implemented?

@nicolaskruchten
Copy link
Owner

The PR is open but I haven't decided to merge it yet. I'm not sure how much I want to support/document/answer questions about such a feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants