Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize TimeControl PGN header support #1033

Open
1 task
niklasf opened this issue Aug 2, 2023 · 2 comments
Open
1 task

Finalize TimeControl PGN header support #1033

niklasf opened this issue Aug 2, 2023 · 2 comments
Labels
enhancement

Comments

@niklasf
Copy link
Owner

niklasf commented Aug 2, 2023

After #1032:

  • Implement setter
@eminyous
Copy link

I am trying to understand the task on this issue and may be implementing it. But I don't understand where do you want to add a setter? Is it in the Game class or other?

@niklasf
Copy link
Owner Author

niklasf commented Sep 29, 2023

Yes, next to

python-chess/chess/pgn.py

Line 896 in e773cd4

def time_control(self) -> TimeControl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niklasf @eminyous