Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regain performance lost after switch from mmap to buffered IO #12

Open
niklasf opened this issue Jan 29, 2019 · 2 comments
Open

Regain performance lost after switch from mmap to buffered IO #12

niklasf opened this issue Jan 29, 2019 · 2 comments

Comments

@niklasf
Copy link
Owner

niklasf commented Jan 29, 2019

No description provided.

@thomasahle
Copy link

Does this mean the benchmarks on https://github.com/niklasf/rust-pgn-reader are no longer valid? Can one simply use an older version to still achieve those speeds?

@niklasf
Copy link
Owner Author

niklasf commented Jan 5, 2021

The benchmarks (v0.12.0) are after this regression.

You can downgrade to v0.11.0 to use the mmap based reader for even better speeds, but there have been bugfixes in dependencies, added features, and there is some controversy about using mmap in Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants