Bug in length of stem

[Adelija]

Hello Nikola,
I am using your stemmer and it's quite good. You wrote in your paper related to Stemmer that minimal length of stem should be more than 2.
But in both method stem_arr(str) and stem_str(str)
if(word.endswith(key) and len(word)>2):
return stem with length 2. for example, words plaše, plovan, pleva return the same stem "pl". Maybe you should change that line of code with
if(word.endswith(key) and len(word)-len(key)>2):
Am I right?

[nikolamilosevic86]

Hello Adelija,
I suppose that in one degree it is right. Although, the code in comment states that the statement prevents stemming of words that do have total length or 2. For example like "na", "da", "ja"... These words should not be stemmed as it does not make sense. Stem could be length 2 or more.
The correct code should probably be
if(word.endswith(key) and len(word)>2 and len(word)-len(key)>2):

However that can be simplified to what you said. I see you already forked the project. Do you want to do pull request and I will accept it?

[Adelija]

Ok Nikola, Have you used this stemmer like this? I am asking you because i changes something in order to make it rihgt for my usage and I would like to know is there potential mistakes i didn't see. That could make me problem 😀 How to pull? I tried but there is no differences. I have no experiance here, sorry.

On uto, 14. nov 2017. at 23.56 Nikola Milosevic ***@***.***> wrote: Hello Adelija, I suppose that in one degree it is right. Although, the code in comment states that the statement prevents stemming of words that do have total length or 2. For example like "na", "da", "ja"... These words should not be stemmed as it does not make sense. Stem could be length 2 or more. The correct code should probably be if(word.endswith(key) and len(word)>2 and len(word)-len(key)>2): However that can be simplified to what you said. I see you already forked the project. Do you want to do pull request and I will accept it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AID1sewN_b0SbjqJ5Ig_Bv4xaHVJrG5iks5s2hqZgaJpZM4QeHhw> .

-- Adela Ljajić