FIX: Inefficient iterative reloading of reference and moving images #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list comprehension had ``nb.loads`` and other method calls continously happening when converting the affine array into RAS.
effigies
reviewed
Nov 16, 2023
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
effigies
reviewed
Nov 16, 2023
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 96.95% 96.97% +0.02%
==========================================
Files 13 13
Lines 1279 1289 +10
Branches 184 252 +68
==========================================
+ Hits 1240 1250 +10
Misses 33 33
Partials 6 6 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list comprehension had
nb.loads and other method calls continously happening when converting the affine array into RAS.