Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Add resamping.apply to top module imports #227

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Oct 10, 2024

This PR is for convenience after #195

@effigies
Copy link
Member

effigies commented Oct 10, 2024

I've been thinking that maybe apply() isn't a great name. nitransforms.apply() is at least clear what kind of thing is being applied, but maybe we really want nitransforms.resample() to be explicit about how we're applying a transform.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (e7757e2) to head (269bc7f).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   94.65%   94.76%   +0.11%     
==========================================
  Files          15       15              
  Lines        1758     1759       +1     
  Branches      329      225     -104     
==========================================
+ Hits         1664     1667       +3     
+ Misses         77       76       -1     
+ Partials       17       16       -1     
Flag Coverage Δ
unittests 94.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mgxd
Copy link
Member Author

mgxd commented Oct 10, 2024

Yeah technically true - I wouldn't be opposed. Just quickly started aggregating a list of what other tools are calling this, seems it goes either way.

Other tools
ANTs: ApplyTransforms
FSL: ApplyXFM
Workbench: -{volume, surface, ...}-resample
FreeSurfer: vol2vol

I do think it should be consistently named throughout (no aliasing at the top level), so if we decided to go forward with that let's do it in a separate API breaking PR

@effigies
Copy link
Member

Also: skimage.warp

@mgxd mgxd merged commit 7dfcb37 into nipy:master Nov 18, 2024
16 checks passed
@mgxd mgxd deleted the enh/apply-import branch November 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants