Merge pull request #130 from asalkeld/target-parsing

fix(target): Parsing of extra targets
nitrictech · Mar 1, 2022 · a1faea7 · a1faea7
2 parents ad846dd + fdad3fc
commit a1faea7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/pkg/target/options.go b/pkg/target/options.go
@@ -89,7 +89,8 @@ func AllFromConfig() (map[string]Target, error) {
 		if err != nil {
 			return nil, err
 		}
-		if len(tMap) > 3 {
+
+		if len(tMap) > 2 {
 			// Decode the "extra" map for provider specific values
 			delete(tMap, "provider")
 			delete(tMap, "region")

diff --git a/pkg/target/options_test.go b/pkg/target/options_test.go
@@ -79,6 +79,24 @@ func TestFromOptions(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:   "from config with extra 1",
+			target: "gcp",
+			config: map[string]map[string]interface{}{
+				"gcp": {
+					"provider": "gcp",
+					"region":   "australia-southeast1",
+					"project":  "avid-life-342120",
+				},
+			},
+			want: &Target{
+				Provider: Gcp,
+				Region:   "australia-southeast1",
+				Extra: map[string]interface{}{
+					"project": "avid-life-342120",
+				},
+			},
+		},
 		{
 			name:        "from args",
 			provider:    "azure",