Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a_u=None edge case #20

Closed
wegank opened this issue Apr 8, 2024 · 1 comment
Closed

a_u=None edge case #20

wegank opened this issue Apr 8, 2024 · 1 comment

Comments

@wegank
Copy link

wegank commented Apr 8, 2024

I hit an edge case when relabelling NixOS/nixpkgs#301947, where the first approver (@a-n-n-a-l-e-e) deleted their account.

INFO:root:Processing 301947
INFO:root:lastappdate: 2024-04-06 11:06:06
INFO:root:lastcommitdate: 2024-04-05 23:44:16
INFO:root:Removing label '12.approvals: 2' from PR: '301947' https://github.com/NixOS/nixpkgs/pull/301947
INFO:root:Adding label '12.approvals: 1' to PR: '301947' https://github.com/NixOS/nixpkgs/pull/301947
Traceback (most recent call last):
  File "/nix/store/62r1p3rnaa0qw0fms8pw3i0q07if6xyp-label-approved-0.1.0/bin/.label-approved-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/62r1p3rnaa0qw0fms8pw3i0q07if6xyp-label-approved-0.1.0/lib/python3.10/site-packages/label_approved/cli.py", line 191, in main
    process_pr(g_h, p_r_as_issue.as_pull_request(), dry_run=args.dry_run)
  File "/nix/store/62r1p3rnaa0qw0fms8pw3i0q07if6xyp-label-approved-0.1.0/lib/python3.10/site-packages/label_approved/cli.py", line 148, in process_pr
    if a_u.login.lower() in maintainers:
AttributeError: 'NoneType' object has no attribute 'login'
@Artturin
Copy link
Member

Artturin commented Apr 8, 2024

#21

@wegank wegank closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants