From 8aadc6ca70c731e3322c8000efc0d59c05aa0269 Mon Sep 17 00:00:00 2001 From: "Martin Hinshelwood nkdAgility.com" Date: Wed, 20 Mar 2024 14:11:33 +0000 Subject: [PATCH] [preview] Cleanup (#1995) --- configuration.json | 3 --- configuration2-wit.json | 3 +-- configuration2.json | 3 +-- docs/Reference/Generated/MigrationTools.xml | 14 -------------- ...e.v1.processors.workitemmigrationcontext.yaml | 10 ---------- ...nce.v1.processors.workitemmigrationcontext.md | 12 +----------- src/MigrationTools.Samples/configuration.json | 6 +----- .../Processing/WorkItemMigrationConfig.cs | 16 ---------------- 8 files changed, 4 insertions(+), 63 deletions(-) diff --git a/configuration.json b/configuration.json index 0511490b3..859b9cdef 100644 --- a/configuration.json +++ b/configuration.json @@ -102,14 +102,11 @@ "UpdateCreatedDate": true, "UpdateCreatedBy": true, "WIQLQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.Id] =137 AND [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Program', 'Portfolio', 'Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') ORDER BY [System.ChangedDate] desc", - "LinkMigration": true, "FixHtmlAttachmentLinks": false, - "SkipToFinalRevisedWorkItemType": false, "WorkItemCreateRetryLimit": 5, "FilterWorkItemsThatAlreadyExistInTarget": false, "PauseAfterEachWorkItem": false, "AttachRevisionHistory": false, - "LinkMigrationSaveEachAsAdded": false, "GenerateMigrationComment": true, "WorkItemIDs": null, "MaxGracefulFailures": 0, diff --git a/configuration2-wit.json b/configuration2-wit.json index c7fc4bb56..0cbb1db94 100644 --- a/configuration2-wit.json +++ b/configuration2-wit.json @@ -134,8 +134,7 @@ }, { "$type": "TfsWorkItemLinkEnricherOptions", - "Enabled": true, - "LinkMigrationSaveEachAsAdded": false + "Enabled": true }, { "$type": "TfsWorkItemCreatedEnricherOptions", diff --git a/configuration2.json b/configuration2.json index bcc42c749..b56c53443 100644 --- a/configuration2.json +++ b/configuration2.json @@ -242,8 +242,7 @@ }, { "$type": "TfsWorkItemLinkEnricherOptions", - "Enabled": true, - "LinkMigrationSaveEachAsAdded": true + "Enabled": true }, { "$type": "TfsWorkItemCreatedEnricherOptions", diff --git a/docs/Reference/Generated/MigrationTools.xml b/docs/Reference/Generated/MigrationTools.xml index dd598bed6..b384d763b 100644 --- a/docs/Reference/Generated/MigrationTools.xml +++ b/docs/Reference/Generated/MigrationTools.xml @@ -389,13 +389,6 @@ ? - - - **beta** If enabled this will fix any image attachments URL's, work item mention URL's or user mentions in the HTML fields as well as discussion comments. You must specify a - PersonalAccessToken in the Source project for Azure DevOps; TFS should use integrated authentication. - - false - **beta** If set to a number greater than 0 work items that fail to save will retry after a number of seconds equal to the retry count. @@ -422,13 +415,6 @@ ? - - - If you have changed parents before re-running a sync you may get a `TF26194: unable to change the value of the 'Parent' field` error. - This will resolve it, but will slow migration. - - false - If enabled, adds a comment recording the migration diff --git a/docs/_data/reference.v1.processors.workitemmigrationcontext.yaml b/docs/_data/reference.v1.processors.workitemmigrationcontext.yaml index c343da698..216e119a0 100644 --- a/docs/_data/reference.v1.processors.workitemmigrationcontext.yaml +++ b/docs/_data/reference.v1.processors.workitemmigrationcontext.yaml @@ -11,12 +11,10 @@ configurationSamples: "UpdateCreatedBy": true, "WIQLQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') ORDER BY [System.ChangedDate] desc", "FixHtmlAttachmentLinks": false, - "SkipToFinalRevisedWorkItemType": false, "WorkItemCreateRetryLimit": 5, "FilterWorkItemsThatAlreadyExistInTarget": false, "PauseAfterEachWorkItem": false, "AttachRevisionHistory": false, - "LinkMigrationSaveEachAsAdded": false, "GenerateMigrationComment": true, "WorkItemIDs": null, "MaxGracefulFailures": 0, @@ -49,10 +47,6 @@ options: type: Boolean description: If enabled, adds a comment recording the migration defaultValue: false -- parameterName: LinkMigrationSaveEachAsAdded - type: Boolean - description: "If you have changed parents before re-running a sync you may get a `TF26194: unable to change the value of the 'Parent' field` error. This will resolve it, but will slow migration." - defaultValue: false - parameterName: MaxGracefulFailures type: Int32 description: The maximum number of failures to tolerate before the migration fails. When set above zero, a work item migration error is logged but the migration will continue until the number of failed items reaches the configured value, after which the migration fails. @@ -69,10 +63,6 @@ options: type: Boolean description: This will skip a revision if the source iteration has not been migrated i.e. it was deleted defaultValue: missng XML code comments -- parameterName: SkipToFinalRevisedWorkItemType - type: Boolean - description: "**beta** If enabled this will fix any image attachments URL's, work item mention URL's or user mentions in the HTML fields as well as discussion comments. You must specify a PersonalAccessToken in the Source project for Azure DevOps; TFS should use integrated authentication." - defaultValue: false - parameterName: UpdateCreatedBy type: Boolean description: "If this is enabled the creation process on the target project will create the items with the original creation date. (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate, not the internal create date)" diff --git a/docs/collections/_reference/reference.v1.processors.workitemmigrationcontext.md b/docs/collections/_reference/reference.v1.processors.workitemmigrationcontext.md index 291fa6683..dd5244fc7 100644 --- a/docs/collections/_reference/reference.v1.processors.workitemmigrationcontext.md +++ b/docs/collections/_reference/reference.v1.processors.workitemmigrationcontext.md @@ -12,12 +12,10 @@ configurationSamples: "UpdateCreatedBy": true, "WIQLQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') ORDER BY [System.ChangedDate] desc", "FixHtmlAttachmentLinks": false, - "SkipToFinalRevisedWorkItemType": false, "WorkItemCreateRetryLimit": 5, "FilterWorkItemsThatAlreadyExistInTarget": false, "PauseAfterEachWorkItem": false, "AttachRevisionHistory": false, - "LinkMigrationSaveEachAsAdded": false, "GenerateMigrationComment": true, "WorkItemIDs": null, "MaxGracefulFailures": 0, @@ -50,10 +48,6 @@ options: type: Boolean description: If enabled, adds a comment recording the migration defaultValue: false -- parameterName: LinkMigrationSaveEachAsAdded - type: Boolean - description: "If you have changed parents before re-running a sync you may get a `TF26194: unable to change the value of the 'Parent' field` error. This will resolve it, but will slow migration." - defaultValue: false - parameterName: MaxGracefulFailures type: Int32 description: The maximum number of failures to tolerate before the migration fails. When set above zero, a work item migration error is logged but the migration will continue until the number of failed items reaches the configured value, after which the migration fails. @@ -70,10 +64,6 @@ options: type: Boolean description: This will skip a revision if the source iteration has not been migrated i.e. it was deleted defaultValue: missng XML code comments -- parameterName: SkipToFinalRevisedWorkItemType - type: Boolean - description: "**beta** If enabled this will fix any image attachments URL's, work item mention URL's or user mentions in the HTML fields as well as discussion comments. You must specify a PersonalAccessToken in the Source project for Azure DevOps; TFS should use integrated authentication." - defaultValue: false - parameterName: UpdateCreatedBy type: Boolean description: "If this is enabled the creation process on the target project will create the items with the original creation date. (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate, not the internal create date)" @@ -251,7 +241,7 @@ topics: - topic: introduction path: /docs/Reference/v1/Processors/WorkItemMigrationContext-introduction.md exists: true - markdown: >+ + markdown: > The `WorkItemMigrationContext` processor is used for migrating work items from one Azure DevOps instance to another. This encompasses a variety of activities: diff --git a/src/MigrationTools.Samples/configuration.json b/src/MigrationTools.Samples/configuration.json index 5d8c9af5f..7844f7cca 100644 --- a/src/MigrationTools.Samples/configuration.json +++ b/src/MigrationTools.Samples/configuration.json @@ -128,17 +128,13 @@ "AppendMigrationToolSignatureFooter": false, "WiqlQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan')", "Enabled": true, - "LinkMigration": true, "AttachmentMigration": true, "AttachmentWorkingPath": "c:\\temp\\WorkItemAttachmentWorkingFolder\\", "FixHtmlAttachmentLinks": false, - "SkipToFinalRevisedWorkItemType": false, "WorkItemCreateRetryLimit": 5, "FilterWorkItemsThatAlreadyExistInTarget": true, "PauseAfterEachWorkItem": false, - "AttachmentMaxSize": 480000000, - "CollapseRevisions": false, - "LinkMigrationSaveEachAsAdded": false + "CollapseRevisions": false } ] } diff --git a/src/MigrationTools/_EngineV1/Configuration/Processing/WorkItemMigrationConfig.cs b/src/MigrationTools/_EngineV1/Configuration/Processing/WorkItemMigrationConfig.cs index 6ed681219..c02668c14 100644 --- a/src/MigrationTools/_EngineV1/Configuration/Processing/WorkItemMigrationConfig.cs +++ b/src/MigrationTools/_EngineV1/Configuration/Processing/WorkItemMigrationConfig.cs @@ -48,13 +48,6 @@ public class WorkItemMigrationConfig : IWorkItemProcessorConfig /// ? public bool FixHtmlAttachmentLinks { get; set; } - /// - /// **beta** If enabled this will fix any image attachments URL's, work item mention URL's or user mentions in the HTML fields as well as discussion comments. You must specify a - /// PersonalAccessToken in the Source project for Azure DevOps; TFS should use integrated authentication. - /// - /// false - public bool SkipToFinalRevisedWorkItemType { get; set; } - /// /// **beta** If set to a number greater than 0 work items that fail to save will retry after a number of seconds equal to the retry count. /// This allows for periodic network glitches not to end the process. @@ -81,13 +74,6 @@ public class WorkItemMigrationConfig : IWorkItemProcessorConfig /// ? public bool AttachRevisionHistory { get; set; } - /// - /// If you have changed parents before re-running a sync you may get a `TF26194: unable to change the value of the 'Parent' field` error. - /// This will resolve it, but will slow migration. - /// - /// false - public bool LinkMigrationSaveEachAsAdded { get; set; } - /// /// If enabled, adds a comment recording the migration /// @@ -134,8 +120,6 @@ public WorkItemMigrationConfig() FixHtmlAttachmentLinks = false; UpdateCreatedBy = true; UpdateCreatedDate = true; - SkipToFinalRevisedWorkItemType = false; - LinkMigrationSaveEachAsAdded = false; GenerateMigrationComment = true; WIQLQuery = @"SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') ORDER BY [System.ChangedDate] desc"; AttachRevisionHistory = false;