TfsUserMappingTool: File not loading and users not mapping.

[maloups]

Hi,

I'm trying to understand how the "TfsUserMappingTool" component works (I use version "16.0.3").
In my "Source" Tenant, the users are of the form "MyLastane, MyFirstname".
In the "Target" Tenant, the users are of the form "MyFirstname MyLastane".
So the mapping with WorkItems is not done correctly during migration.
I have made several attempts but on each attempt I get the error message

"TfsUserMappingTool::GetMappingFileData::No User Mapping file Provided! Provide file or disable TfsUserMappingTool"

The contents of my configuration file

{
  "Serilog": {
    "MinimumLevel": "Debug"
  },
  "MigrationTools": {
    "Version": "16.0",
    "Endpoints": {
      "Source": {
        "EndpointType": "TfsTeamProjectEndpoint",
        "Collection": "https://dev.azure.com/MyCompagnyA/",
        "Project": "ZApplications",
        "Authentication": {
          "AuthenticationMode": "AccessToken",
          "AccessToken": "xxxxxxxxxxxx"
        },
        "ReflectedWorkItemIdField": "ReflectedWorkItemId",
        "AllowCrossProjectLinking": true,
        "LanguageMaps": {
          "AreaPath": "Area",
          "IterationPath": "Iteration"
        },
        "EndpointEnrichers": null
      },
      "Target": {
        "EndpointType": "TfsTeamProjectEndpoint",
        "Collection": "https://dev.azure.com/OtherCompagny/",
        "Project": "ZApplications",
        "Authentication": {
          "AuthenticationMode": "AccessToken",
          "AccessToken": "xxxxxxxxxxxx"
        },
        "ReflectedWorkItemIdField": "ReflectedWorkItemId",
        "AllowCrossProjectLinking": true,
        "LanguageMaps": {
          "AreaPath": "Area",
          "IterationPath": "Iteration"
        },
        "EndpointEnrichers": null
      }
    },
    "Processors": [
      {
        "ProcessorType": "TfsWorkItemMigrationProcessor",
        "Enabled": true,
        "UpdateCreatedDate": false,
        "UpdateCreatedBy": false,
        "WIQLQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') AND [System.Id] = '353133' ORDER BY [System.ChangedDate] desc",
        "FixHtmlAttachmentLinks": true,
        "WorkItemCreateRetryLimit": 5,
        "FilterWorkItemsThatAlreadyExistInTarget": false,
        "PauseAfterEachWorkItem": false,
        "AttachRevisionHistory": false,
        "GenerateMigrationComment": false,
        "WorkItemIDs": null,
        "MaxGracefulFailures": 0,
        "SkipRevisionWithInvalidIterationPath": false,
        "SkipRevisionWithInvalidAreaPath": false,
        "SourceName": "Source",
        "TargetName": "Target",
        "RefName": null
      },
      {
        "ProcessorType": "TfsExportUsersForMappingProcessor",
        "Enabled": false,
        "OnlyListUsersInWorkItems": true,
        "WIQLQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') AND [System.Id] = '353133' ORDER BY [System.ChangedDate] desc",
        "SourceName": "Source",
        "TargetName": "Target"
      }
    ],
    "CommonTools": {
      "TfsUserMappingTool": {
        "Enabled": true,
        "UserMappingFile": "C:\\temp\\userExport.json",
        "IdentityFieldsToCheck": [
          "System.AssignedTo",
          "System.ChangedBy",
          "System.CreatedBy",
          "Microsoft.VSTS.Common.ActivatedBy",
          "Microsoft.VSTS.Common.ResolvedBy",
          "Microsoft.VSTS.Common.ClosedBy"
        ]
      }
    }
  }
}

The contents of my file "C:\temp\userExport.json"

[
  {
    "Source": {
      "FriendlyName": "MyLastane, MyFirstname",
      "AccountName": "MC9999@MyCompagnyA.onmicrosoft.com"
    },
    "target": {
      "FriendlyName": "MyFirstname MyLastane",
      "AccountName": "MyFirstname.MyLastane@OtherCompagny.com"
    }
  }
]

Did I miss something?
Thank you in advance for your feedback.

[MrHinsh]

You found a bug as #2416!

Fix inbound! Should be in v16.0.4-Preview.6 once it ships...

[maloups]

Thanks for the quick fix!
I no longer have file loading errors with this new version.
When I look at the logs I see a match but it does not seem to be applied.
No particular error, but my workitem always remains referenced with the original user.
Attached is an extract from the logs, if you have any ideas I am interested?
usermapping.log

[MrHinsh]

Ive put some extra debugging into a new PR... here is how to access:

1. Open https://github.com/nkdAgility/azure-devops-migration-tools/actions/workflows/main.yml?query=branch%3Atopic%2Fmore-UserMpaping-Shenanigans and select the latest successful build.
2. Scroll down to Artifacts and download AzureDevOpsMigrationTools-Packages
3. Open the zip and find MigrationTools-16.0.4-PullRequest*.zip, extract it, and unblock it before extracting
4. Extract and run from there...

The extra debug will output the Log.LogDebug($"TfsUserMappingTool::MapUserIdentityField::Map:[original|{original}][new|{field.Value}]"); which might shed some light...

[maloups]

usermapping-debug.log
Sorry for the slightly late response.
Attached is the log file, but I don't see any additional information

[MrHinsh]

It looks like its mapping on System.CreatedBy | Source:MyLastane, MyFirstname <MC9999@MyCompagnyA.onmicrosoft.com> Target:MyFirstname MyLastane

[MrHinsh]

I'd recommned debugging and seeing whats yup! Are you able to fork the repo and run your migration in visual studio?

[maloups]

Sorry but I'm not a developer, I don't have Visual Studio and my client doesn't want me to spend more time on this subject (but I can possibly test other releases if necessary) :-)