From 716dcdb6c443eaa5f88eab19214f92da9ff66380 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 18 Jun 2024 03:41:14 +0000 Subject: [PATCH 1/3] build(deps-dev): bump rubocop-rspec from 2.25.0 to 3.0.1 Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.25.0 to 3.0.1. - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.25.0...v3.0.1) --- updated-dependencies: - dependency-name: rubocop-rspec dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 89ff1e8d..2adb194a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -461,10 +461,6 @@ GEM unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.31.3) parser (>= 3.3.1.0) - rubocop-capybara (2.19.0) - rubocop (~> 1.41) - rubocop-factory_bot (2.24.0) - rubocop (~> 1.33) rubocop-performance (1.21.1) rubocop (>= 1.48.1, < 2.0) rubocop-ast (>= 1.31.1, < 2.0) @@ -473,10 +469,8 @@ GEM rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) rubocop-ast (>= 1.30.0, < 2.0) - rubocop-rspec (2.25.0) - rubocop (~> 1.40) - rubocop-capybara (~> 2.17) - rubocop-factory_bot (~> 2.22) + rubocop-rspec (3.0.1) + rubocop (~> 1.61) ruby-next-core (1.0.3) ruby-progressbar (1.13.0) ruby-statistics (3.0.2) From fe114106985b37514952c2de0c9e86f3322ccd59 Mon Sep 17 00:00:00 2001 From: Yetrina Battad Date: Tue, 18 Jun 2024 13:46:25 +1000 Subject: [PATCH 2/3] build: fix rubocop dependencies --- Gemfile | 1 + Gemfile.lock | 3 +++ .../breadcrumbs_hierarchy_component_spec.rb | 16 ++++++++-------- spec/system/nav_actions_spec.rb | 4 ++-- 4 files changed, 14 insertions(+), 10 deletions(-) diff --git a/Gemfile b/Gemfile index e5aed29e..e0a6b37a 100644 --- a/Gemfile +++ b/Gemfile @@ -101,6 +101,7 @@ group :development, :test do gem "rubocop-rails", require: false gem "rubocop-rspec", require: false gem "rubocop-performance", require: false + gem "rubocop-capybara", require: false gem "solr_wrapper", ">= 0.3" gem "rspec-rails", "~> 6.1" diff --git a/Gemfile.lock b/Gemfile.lock index 2adb194a..43b352f9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -461,6 +461,8 @@ GEM unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.31.3) parser (>= 3.3.1.0) + rubocop-capybara (2.21.0) + rubocop (~> 1.41) rubocop-performance (1.21.1) rubocop (>= 1.48.1, < 2.0) rubocop-ast (>= 1.31.1, < 2.0) @@ -643,6 +645,7 @@ DEPENDENCIES redis (~> 5.1) rsolr (>= 1.0, < 3) rspec-rails (~> 6.1) + rubocop-capybara rubocop-performance rubocop-rails rubocop-rspec diff --git a/spec/components/arclight/breadcrumbs_hierarchy_component_spec.rb b/spec/components/arclight/breadcrumbs_hierarchy_component_spec.rb index 4ecb03ee..8e3426a0 100644 --- a/spec/components/arclight/breadcrumbs_hierarchy_component_spec.rb +++ b/spec/components/arclight/breadcrumbs_hierarchy_component_spec.rb @@ -22,7 +22,7 @@ expect(page).to have_css "li", text: "National Library of Australia" expect(page).to have_css "li", text: "Guide to the ABC123" - expect(page).not_to have_link "Guide to the ABC123" + expect(page).to have_no_link "Guide to the ABC123" end end @@ -47,11 +47,11 @@ expect(page).to have_link "Guide to the ABC123", href: "/finding-aids/catalog/abc123" expect(page).to have_link "DEF", href: "/finding-aids/catalog/abc123abc123_def" - expect(page).not_to have_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def" + expect(page).to have_no_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def" expect(page).to have_css "li", text: "GHI" - expect(page).not_to have_link "GHI" - expect(page).not_to have_link "Guide to the GHI" + expect(page).to have_no_link "GHI" + expect(page).to have_no_link "Guide to the GHI" end end @@ -76,14 +76,14 @@ expect(page).to have_link "Guide to the ABC123", href: "/finding-aids/catalog/abc123" expect(page).to have_link "DEF", href: "/finding-aids/catalog/abc123abc123_def" - expect(page).not_to have_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def" + expect(page).to have_no_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def" expect(page).to have_link "GHI", href: "/finding-aids/catalog/abc123abc123_ghi" - expect(page).not_to have_link "Guide to the GHI", href: "/finding-aids/catalog/abc123abc123_ghi" + expect(page).to have_no_link "Guide to the GHI", href: "/finding-aids/catalog/abc123abc123_ghi" expect(page).to have_css "li", text: "JKL" - expect(page).not_to have_link "Guide to the JKL" - expect(page).not_to have_link "JKL" + expect(page).to have_no_link "Guide to the JKL" + expect(page).to have_no_link "JKL" end end end diff --git a/spec/system/nav_actions_spec.rb b/spec/system/nav_actions_spec.rb index 1b957444..d0bb5f5e 100644 --- a/spec/system/nav_actions_spec.rb +++ b/spec/system/nav_actions_spec.rb @@ -8,7 +8,7 @@ it "does not show the History link" do visit root_path - expect(page).not_to have_text("History") + expect(page).to have_no_text("History") end context "when FOLIO_UPDATE_IN_PROGRESS is `true`" do @@ -18,7 +18,7 @@ visit root_path - expect(page).not_to have_link I18n.t("blacklight.header_links.login"), href: new_user_session_path + expect(page).to have_no_link I18n.t("blacklight.header_links.login"), href: new_user_session_path end end From cdcc00244f05c80151263677fc1bcc9f66fd3123 Mon Sep 17 00:00:00 2001 From: Yetrina Battad Date: Tue, 18 Jun 2024 14:03:27 +1000 Subject: [PATCH 3/3] build: add rubocop-factory_bot --- Gemfile | 2 ++ Gemfile.lock | 3 +++ 2 files changed, 5 insertions(+) diff --git a/Gemfile b/Gemfile index e0a6b37a..1e963ecc 100644 --- a/Gemfile +++ b/Gemfile @@ -102,6 +102,8 @@ group :development, :test do gem "rubocop-rspec", require: false gem "rubocop-performance", require: false gem "rubocop-capybara", require: false + gem "rubocop-factory_bot", require: false + gem "solr_wrapper", ">= 0.3" gem "rspec-rails", "~> 6.1" diff --git a/Gemfile.lock b/Gemfile.lock index 43b352f9..1a622e9a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -463,6 +463,8 @@ GEM parser (>= 3.3.1.0) rubocop-capybara (2.21.0) rubocop (~> 1.41) + rubocop-factory_bot (2.26.1) + rubocop (~> 1.61) rubocop-performance (1.21.1) rubocop (>= 1.48.1, < 2.0) rubocop-ast (>= 1.31.1, < 2.0) @@ -646,6 +648,7 @@ DEPENDENCIES rsolr (>= 1.0, < 3) rspec-rails (~> 6.1) rubocop-capybara + rubocop-factory_bot rubocop-performance rubocop-rails rubocop-rspec