fix: break long url text in map search link and url lists

nla · Sep 5, 2023 · ef4dab5 · ef4dab5
1 parent 0b417a1
commit ef4dab5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -15,9 +15,9 @@ def makelink(document:, href:, text:, classes: "", extended_info: false, longtex
     if text.present? && href.present?
       # if an eResources link, route to offsite handler
       result << if entry.present?
-        link_to(text, offsite_catalog_path(id: document.id, url: href))
+        link_to(text, offsite_catalog_path(id: document.id, url: href), class: "text-break")
       else
-        link_to(text, href)
+        link_to(text, href, class: "text-break")
       end
     end
 

diff --git a/app/helpers/field_helper.rb b/app/helpers/field_helper.rb
@@ -123,7 +123,7 @@ def notes(document:, field:, config:, value:, context:)
   def map_search(document:, field:, config:, value:, context:)
     if value.present?
       # rubocop:disable Rails/OutputSafety
-      link_to("View this map in Map Search", value.first.html_safe)
+      link_to("View this map in Map Search", value.first.html_safe, class: "text-break")
       # rubocop:enable Rails/OutputSafety
     end
   end

diff --git a/spec/helpers/field_helper_spec.rb b/spec/helpers/field_helper_spec.rb
@@ -14,7 +14,7 @@
       let(:value) { [{text: "Text version:", href: "http://purl.access.gpo.gov/GPO/LPS9877"}] }
 
       it "generates a link to the item" do
-        expect(list).to include '<a href="http://purl.access.gpo.gov/GPO/LPS9877">Text version:</a>'
+        expect(list).to include '<a class="text-break" href="http://purl.access.gpo.gov/GPO/LPS9877">Text version:</a>'
       end
     end
 
@@ -293,7 +293,7 @@
     let(:value) { ["https://mapsearch.nla.gov.au/?type=map&mapClassifications=all&geolocation=all&text=113030"] }
 
     it "generates a link to Map Search" do
-      expect(map_search_value).to eq "<a href=\"https://mapsearch.nla.gov.au/?type=map&mapClassifications=all&geolocation=all&text=113030\">View this map in Map Search</a>"
+      expect(map_search_value).to eq '<a class="text-break" href="https://mapsearch.nla.gov.au/?type=map&mapClassifications=all&geolocation=all&text=113030">View this map in Map Search</a>'
     end
 
     context "when there is no value" do