From ef344f716f8a25facbf12580c03e3ed3a47d9285 Mon Sep 17 00:00:00 2001 From: matt Date: Sun, 9 Oct 2022 09:50:22 -0500 Subject: [PATCH] Update news/cran comments --- NEWS.md | 4 ++++ cran-comments.md | 23 +++++++---------------- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/NEWS.md b/NEWS.md index dc05b14..c765b39 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# dparser 1.3.1-7 + +* Fixed one remaining strict typing issue, as requested by CRAN. + # dparser 1.3.1-6 * Updated dparser header to have strict typing, as requested by CRAN. diff --git a/cran-comments.md b/cran-comments.md index 784dcc1..4dafaa2 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,23 +1,14 @@ # Comments -* Prof Ripley said: +Matthew, +You submitted too soon, so the incoming check systems did not have +-Wstrict-prototypes turned on yet, and did not catch the remaining -[Packages listed above] import headers from -the one on the left with some 'prototypes' fn () . Compiling using +Found the following significant warnings: + lr.c:27:15: warning: function declaration isn’t a prototype [-Wstrict-prototypes] --Wstrict-prototypes +Should be in place now, can you please fix the remaining warning too? -in CFLAGS (with gcc or clang < 15: this is implied by -pedantic in clang -15) shows warnings that are starting to show up on the CRAN results -pages, and will be used for CRAN incoming checks. +* Fixed -Some of these seem intended to be a function with no arguments, for -which the prototype is fn (void) . But for others, consistency checks -are being circumvented by not using a full prototype. In packages not -reported here these have shown up several bugs already .... - -Please correct (in the packages before the colon) before 2022-11-04. - -* This fix corrects this for dparser -* Also added back restriction fix that accidentally was deleted when pulling from upstream.