Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rxode2::etTrans() instead of nlmixr_data_simplify() #13

Closed
billdenney opened this issue Mar 8, 2024 · 3 comments
Closed

Use rxode2::etTrans() instead of nlmixr_data_simplify() #13

billdenney opened this issue Mar 8, 2024 · 3 comments

Comments

@billdenney
Copy link
Collaborator

@mattfidler, In an initial test, rxode2::etTrans() drops the MDV column. This could be important for nlmixr2targets in case the MDV column changes. Mainly, I want to be sure that all columns are captured. Since etTrans() is an rxode2 function, might it miss any columns that are estimation-focused rather than integration-focused.

@mattfidler
Copy link
Member

mattfidler commented Mar 8, 2024

@billdenney You are right. MDV is not used by nlmixr2 or rxode2, it simply translates it to an EVID equivalent.

As I was thinking, there are a few things that may change though:

  • IDs may change, they are saved as factor information in etTrans()
  • Time varying covariates and non-time-varying covariates are separated (and handled differently).

Perhaps it is easier to simply use nlmixr_data_simplify()

@mattfidler
Copy link
Member

(Mostly for the ID issue. Also using etTrans directly has not been widely tested so there may be some edge cases that I am not anticipating).

@billdenney
Copy link
Collaborator Author

It sounds like long-term solution could be to have this in rxode2::etTrans(), but the today solution is to use nlmixr_data_simplify().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants