Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make meanEdgeLength public in PoissonDiskSampler #183

Closed
dyollb opened this issue Aug 8, 2024 · 1 comment
Closed

Make meanEdgeLength public in PoissonDiskSampler #183

dyollb opened this issue Aug 8, 2024 · 1 comment

Comments

@dyollb
Copy link
Contributor

dyollb commented Aug 8, 2024

The parameter rCoeff in PoissonDiskSampler is used to compute the minimum distance between points

minDist = rCoeff * meanEdgeLength;

The value meanEdgeLength is computed by PoissonDiskSampler and stored as member. If I want to sample a surface with a known minDist I need to compute the meanEdgeLength myself in order to specify rCoeff as minDist / meanEdgeLength.
I would propose to add a getter to get the mean edge length, e.g.

class PoissonDiskSampler {
...
double getMeanEdgeLength() const { return meanEdgeLength; }
...
};
dyollb added a commit to dyollb/geometry-central that referenced this issue Aug 19, 2024
@dyollb
Copy link
Contributor Author

dyollb commented Aug 26, 2024

fixed by #186 - meanEdgeLength is no longer needed to compute relative sample distance.

@dyollb dyollb closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant