Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full Docker support for ROCm #4

Open
jakki-amd opened this issue Nov 12, 2024 · 0 comments
Open

Add full Docker support for ROCm #4

jakki-amd opened this issue Nov 12, 2024 · 0 comments
Labels
backend Updates related to backend docker Updates related to docker and related files enhancement New feature or request

Comments

@jakki-amd
Copy link
Collaborator

Problem

Currently, ROCm is only supported in docker/Dockerfile.dev file that has been deprecated. TorchServe uses docker/build_image.sh script and docker/Dockerfile to create Docker images. This way of creating Docker images is currently not supported regarding ROCm.

Solution

  • Add ROCm support for the main Dockerfile
  • Add ROCM_VERSION option to docker/build_image.sh file
@eppane eppane added docker Updates related to docker and related files enhancement New feature or request backend Updates related to backend labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Updates related to backend docker Updates related to docker and related files enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eppane @jakki-amd