Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish the standard process to introduce new features in machine learning repository (this repository) #139

Open
nodchip opened this issue Sep 11, 2020 · 0 comments

Comments

@nodchip
Copy link
Owner

nodchip commented Sep 11, 2020

We could be better to establish the standard process to introduce new features in this repository. The objective of the process is:

  • Simplify the process.
  • Avoid evaluation dependent on individual skills.
  • Avoid regressions.
  • Avoid bad changes which decrease the elo.

My current suggestion is:

  1. Discuss in Discord.
  2. Create a pull request to implement a new feature.
    • In this timing, the new feature should be disabled by an option.
  3. Create an issue to experiment the new feature.
    • In the experiment, we should record and share the experiment environment (OS, CPU, Memory, ...), all the commands and the results.
    • fishtest is used to compare the elos.
  4. Create a pull request to enable the new feature by default, and update documents (Readme.md, etc...).

I created example issues about 3.

I'd like to hear other's opinions. Any comments are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant