Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race conditions in the code. #164

Open
vondele opened this issue Sep 20, 2020 · 5 comments · Fixed by #200
Open

race conditions in the code. #164

vondele opened this issue Sep 20, 2020 · 5 comments · Fixed by #200
Labels
bug Something isn't working

Comments

@vondele
Copy link
Collaborator

vondele commented Sep 20, 2020

current gensfen and learn commands are not correct multithreaded, several races remain. To check:

make clean && make -j2 ARCH=x86-64-modern sanitize=thread    optimize=no debug=yes build > /dev/null && ../tests/instrumented_learn.sh --sanitizer-thread
@Sopel97 Sopel97 mentioned this issue Sep 25, 2020
Merged
@vondele
Copy link
Collaborator Author

vondele commented Sep 25, 2020

@Sopel97 maybe you can test if this is fixed by adding that line to .travis.yml ?

@Sopel97 Sopel97 mentioned this issue Oct 20, 2020
Merged
@vondele
Copy link
Collaborator Author

vondele commented Oct 21, 2020 •
edited
Loading

@nodchip @Sopel97 this was auto-closed on merge, maybe we can explicitly add the line above to CI, to make sure it is fixed.

@Sopel97
Copy link
Collaborator

Sopel97 commented Oct 21, 2020

Right, not sure why this was closed straight up. There may still be issues in gensfen. I'd reopen this for now, later I'll try adding the CI tasks when I reduce the bench depth in valgrind.

@vondele
Copy link
Collaborator Author

vondele commented Oct 21, 2020 •
edited
Loading

doesn't look like I can reopen @nodchip should have the permission to do that.

github will auto-close issues if the commit message says fixes #1234 unfortunately also for 'maybe fixes' 'partially fixes' etc.

@nodchip nodchip reopened this Oct 21, 2020
@nodchip
Copy link
Owner

nodchip commented Oct 21, 2020

I reopened this issue.

@Sopel97 Sopel97 added the bug Something isn't working label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make learner work on top of stockfish's thread pool instead of MultiThink. Sopel97/Stockfish
3 participants
@nodchip @vondele @Sopel97