From ae00a73394e9d61ce61b1c587df100e492d0cf3c Mon Sep 17 00:00:00 2001 From: Gaby Baghdadi <49249542+gabylb@users.noreply.github.com> Date: Fri, 3 Jul 2020 06:56:46 -0400 Subject: [PATCH] build: disable compiler inlining on z/OS (#146) In Node v14 on z/OS, test `test-exception.js` fails due to a compiler issue with inlining. This PR works around it by disabling compiler inlining. I confirmed that, with this change, `npm test` continues to pass in Node v8.17.0 (which uses D190508 compiler version), as well as in Node v12.16.1 (which uses D191122 as in v14). Once the new Wyvern on z compiler is available for use in Node v14, we'll revisit and undo this change if Woz resolves the issue. PR-URL: https://github.com/nodejs/node-report/pull/146 Reviewed-By: Richard Lau Co-authored-by: baghdadi --- binding.gyp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/binding.gyp b/binding.gyp index 8239288..7fb26be 100644 --- a/binding.gyp +++ b/binding.gyp @@ -14,8 +14,8 @@ "dll_files": [ "dbghelp.dll", "Netapi32.dll", "PsApi.dll", "Ws2_32.dll" ], }], ["OS=='zos'", { - "cflags!": [ "-O2", "-O3" ], - "cflags": [ "-qascii" ], + "cflags!": [ "-O2", "-O3", "-qINLINE=::150:100000" ], + "cflags": [ "-qascii", "-qnoinline" ], }], ], "defines": [