URL unexpectedly removes single digit ports

[rlindner81]

Version

v18.18.2

Platform

Darwin M12VHYH70W 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000 arm64

Subsystem

url

What steps will reproduce the bug?

const { URL } = require("url");

let url;

url = new URL("http://test.com:5");
url.pathname = url.pathname.concat("path");
console.log(url.toString()); // works as expected without url params

url = new URL("http://test.com:5/?param=1");
url.pathname = url.pathname.concat("path");
console.log(url.toString()); // broken

url = new URL("http://test.com:15/?param=1");
url.pathname = url.pathname.concat("path");
console.log(url.toString()); // works as expected with double digit ports

How often does it reproduce? Is there a required condition?

consistently wrong

What is the expected behavior? Why is that the expected behavior?

http://test.com:5/path
http://test.com:5/path?param=1
http://test.com:15/path?param=1

What do you see instead?

http://test.com:5/path
http://test.com/path?param=1
http://test.com:15/path?param=1

Additional information

Having the url parameter set makes urllib forget a single digit port.

[debadree25]

cc @nodejs/url

[aduh95]

I can reproduce on the latest main.

[anonrig]

cc @lemire

[MrJithil]

Great. I can write a fix.

[lemire]

It is indeed a bug in ada-url/ada. I have a verification and a potential fix upstream.

Thank you for the clear report with reproducible cases.

[rlindner81]

@lemire @anonrig Thanks for the very quick fix!

Could you give a rough estimate when this fix will reach v18 bugfix releases?

[lemire]

@anonrig Should be able to tell you.

[baymer]

When will it appear in the 20th node?

[anonrig]

The fix is included in Ada v2.7.3 (Ref commit : ada-url/ada@d4ab1a6). It is not yet merged into Node.js core.

[anonrig]

I retriggered the update script: #50771

[anonrig]

@nodejs/releasers I added lts-watch-v18 and lts-watch-v20 to the version update pull request.