Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log output #256

Open
mircea-c opened this issue Dec 8, 2023 · 0 comments
Open

Fix log output #256

mircea-c opened this issue Dec 8, 2023 · 0 comments

Comments

@mircea-c
Copy link

mircea-c commented Dec 8, 2023

Current JSON logs emitted by nomic binary look like this:

! {"_msg":"executed block","height":11401057,"level":"info","module":"state","num_invalid_txs":0,"num_valid_txs":0,"ts":"2023-12-08T19:26:53.538126559Z"}

! {"_msg":"committed state","app_hash":"ABA390CCF6C431BFE27D8D7E809876CD22ECFA2C1F0730E659D21FFDD3E7A3D5","height":11401057,"level":"info","module":"state","num_txs":0,"ts":"2023-12-08T19:26:53.586123472Z"}

! {"_msg":"indexed block exents","height":11401057,"level":"info","module":"txindex","ts":"2023-12-08T19:26:53.586793819Z"}

The extra ! and newline in between every log line don't seem to serve any actual purpose and are absolute nightmares to deal with when trying to ingest logs in any sort of centralized log storage.

Please fix the logging system to remove these unnecessary characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant