-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating BPMX Model Files into Private PNG Chunks to Display Previews #19
Comments
Cool idea, I've seen something like that at Koikatsu. But what exactly are the compatibility issues and is this a feature you really need? I'm concerned about the increase in bundle size due to the addition of these features |
There are benefits to being able to immediately recognize which model is depicted in a preview image:
Therefore, in my opinion, this file format within a png would likely achieve higher user acceptance and spread more quickly in forums and similar venues. However, the increased bundle size is indeed a significant point of criticism: |
Sorry, "compatibility issues" was an inaccurate ai translation. |
4KB is huge. The bpmx format is a format I made for fast load, so if there's a big overhead here, there's no reason to use it |
I appreciate that you are converting the model files directly into your own format (BPMX). Since you've gone this far, how about storing this file format in a private PNG chunk? This means the file would be hidden within a PNG image.
There are companies that handle it this way in order to display a preview image
without compatibility issuesacross all web browsers and operating systems without the need to install any software/plugins. This could be done with a few lines of code; see: https://github.com/SavAct/pnghideThe text was updated successfully, but these errors were encountered: